Wikipedia:Bots/Requests for approval/PrimeBOT 29

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was

Approved.

PrimeBOT 29

Operator: Primefac (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 01:05, Saturday, August 11, 2018 (UTC)

Automatic, Supervised, or Manual: Automatic

Programming language(s): AWB

Source code available: WP:AWB

Function overview: Replace invalid parameters in {{infobox person}}

Links to relevant discussions (where appropriate): BOTREQ, RFC 1, RFC 2

Edit period(s): One time run

Estimated number of pages affected: Between 5848-16560 (see function details)

Namespace(s): Main

Exclusion compliant (Yes/No): Yes

Function details: Ethnicity (5848 uses) and religion (3890 uses) were removed from {{infobox person}} following the two RFCs listed above. The general consensus is that better infoboxes should be used if religion/ethnicity are relevant to the subject.

In the BOTREQ linked above, an additional valid point was made that this continued proliferation is likely due to copy/pasting existing infoboxes. In the interest of making this a worthwhile venture, I figured that I'd remove or modify the top ~40 parameters with 40+ uses in addition to the religion/ethnicity params. This bot run will remove (list 1) or replace (list 2) invalid parameters. If each parameter use is on its own unique page (unlikely) a total of 16,560 pages will be edited; at minimum 5848.

If deemed a "good thing", I can make these non-minor edits so that users who think the religion/ethnicity/term_start/associated_acts/etc parameters should be valid will be notified and they can change infoboxes.

List 1: remove

ethnicity
(R|r)eligion
imdb_id
notable role
number_of_films
gender
origin
genre
field(s)
language
siblings
dead
country
instrument
branch
background
term_start
period
emmyawards
associated_acts
fullname
term_end
allegiance
grandchildren
battles
workplaces
age

List 2: replace

profession → occupation
Name → name
label → label_name
other_name → other_names
Children → children
size → image_size
hometown → home_town
Spouse → spouse
othernames → other_names
notableworks → notable_works

Discussion

Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete.. With the same remarks as Wikipedia:Bots/Requests for approval/PrimeBOT 28 concerning WP:GENFIXES and User:Headbomb/sandbox#Proposed logic. Headbomb {t · c · p · b} 01:41, 11 August 2018 (UTC)[reply]

Trial complete. - Edits. Primefac (talk) 18:21, 11 August 2018 (UTC)[reply]

@Primefac: can anything be done about the removal of a line break in a nested template? (Or here.) Especially with the new release of AWB which has better nested template logic.Headbomb {t · c · p · b} 12:24, 18 August 2018 (UTC)::This and this and many others add empty lines, this should be tweaked. Headbomb {t · c · p · b} 12:27, 18 August 2018 (UTC)[reply]

This should remove all stray '|' in the infobox. Headbomb {t · c · p · b} 12:29, 18 August 2018 (UTC)[reply]

{{OperatorAssistanceNeeded}} can you incorporate the fix Headbomb suggested above? — xaosflux ^Talk 15:17, 18 August 2018 (UTC)[reply]

~~Seen, travelling, will respond more in full later this week. Primefac (talk) 14:25, 21 August 2018 (UTC)~~[reply]

The short answer is "yes, I should be able to fix the above issues". I just saw the improvements to AWB; I think that will likely affect how my code is parsed (since I have a lot of hardcoded-but-not-great exceptions for nested templates) but should also allow me to get a little more... vigorous with my regex to handle some of the above issues. Would definitely recommend/request another trial. Primefac (talk) 20:13, 23 August 2018 (UTC)[reply]

@Primefac:

Approved for extended trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. proceed when you're ready to. Headbomb {t · c · p · b} 20:56, 23 August 2018 (UTC)[reply]

Issue that got solved

Having a slight issue... As you can see at http://rubular.com/r/gE07i70wKT the regex I've got for handling the "last parameter" works fine, it picks up the }} - in the replacement I replace everything with $6 (or $1, if I remember to ?: all of the other parens). However, in AWB it only picks up | allegiance = {{flagdeco|, leaving behind | allegiance = {{flagdeco|. Can't figure out what's the issue. Primefac (talk) 00:49, 27 August 2018 (UTC)[reply]

Edit/update - I figured out why this behaviour was happening: AWB was ignoring the }} that closed out the template (as I was searching for "in {{infobox person}}"), which means that a) I have to completely rework my code, and b) yes I am still working on this. ~~PrimeBOT (talk) 01:58, 9 September 2018 (UTC)~~ Good lord, I'm an idiot (and tired), didn't see I had logged into PrimeBOT's account to clear out some junk, please forgive the not-approved edits just made to this page. Primefac (talk) 02:00, 9 September 2018 (UTC)[reply]

Trial complete.. Edits. Primefac (talk) 00:18, 10 September 2018 (UTC)[reply]

@Primefac: Reviewing. Some question(s): This removed ethnicity, but not religion. Is that intended? What about Denomination/Birth name/Born? The bot doesn't have to address everything, but since it's going to be doing a lot of edits, it would be good to catch what it can catch.Headbomb {t · c · p · b} 14:43, 11 September 2018 (UTC)[reply]

Some answers

Not intended, but fixed during the Task 28 run - the rule needed to be run multiple times for maximum effectiveness
|denomination= doesn't seem to be on the TemplateData list (nor do I see it in a text-based search), and the others are used <25 times (total), so they can likely be dealt with manually.

My intention with this bot run was to remove all of the parameters that are used often enough that it is a hassle to go through and remove them manually (I mean, I certainly wouldn't want to remove 4000 instances of |religion=). I can certainly add in any additional params if you think they would be useful, but hopefully this bot run will get the tracking cat down to a level where manual editing is once again feasible. Primefac (talk) 02:39, 16 September 2018 (UTC)[reply]

Approved. for general maintenance of {{infobox person}}. No need for further BRFAs for other parameters that are/become deprecated/renamed. Headbomb {t · c · p · b} 14:33, 28 September 2018 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.