Template talk:Chess diagram

Template-protected edit request on 26 January 2024

Can we please add a CSS class of "notheme" to the output of Module:Chessboard, in addition to the "chess-board" class? This will help prevent issues with styling in Dark themes in mobile apps, and will not impact presentation otherwise. (phab:T284327) Dmitry Brant (talk) 13:42, 26 January 2024 (UTC)

 Done – SD0001 (talk) 18:11, 26 January 2024 (UTC)

Colored symbol suggestions

Two suggestions:

1. I propose adding a black border around the white marking symbols. As it is, they kinda blend in when placed on a light square. I have to imagine that that was why the white piece symbols were given black borders, so we might as well do it here, too.
2. Can we get a third type of marking, the ring? It's like the dot, but it has a circular bit missing inside. You use "oO" and "xO" for the white ring and black ring, respectively. It'd be nice to standardize using the ring to indicate non-capturing moves, which applies to the pawn and to many fairy chess pieces. Plus, having a third colored symbol might also come in handy elsewhere (e.g., that one diagram in Castling § History, where we could really use a symbol to fill in the squares given by H. J. R. Murray).

ISaveNewspapers (talk) 02:50, 14 June 2024 (UTC)

Castling also counts as a non-capturing move. ISaveNewspapers (talk) 22:16, 15 June 2024 (UTC)

Edit request 21 August 2024

Description of suggested change: There's an ugly empty row below the chess board if the caption is set to a single newline (see e.g. King's Gambit, Nimzowitsch-Larsen Attack, Petrov's Defence, Two Knights Defense, and Sicilian Defence). Instead of fixing all these articles, let's get rid of this once and for all so that our eyes may finally stop hurting.

Diff:

−

if (footer and footer ~= '') then div:tag('div') :addClass('thumbcaption') :wikitext(footer) end

+

if (footer and mw.text.trim(footer) ~= '') then div:tag('div') :addClass('thumbcaption') :wikitext(footer) end

Dexxor (talk) 10:45, 21 August 2024 (UTC)

This has been added to the sandbox. There is an error in the live version of this module (since May 2013 apparently) and seems to be an issue with the escape patterns in lines 243 and 244. I have made a possible fix in the sandbox. Can you comment on this @Frietjes? — Martin (MSGJ · talk) 16:23, 22 August 2024 (UTC)

MSGJ, seems fine to me. I was first learning LUA back then, so I may have made a mistake with the escape patterns. if it works fine with these changes, then go for it. Frietjes (talk) 16:33, 22 August 2024 (UTC)

 Done — Martin (MSGJ · talk) 08:32, 23 August 2024 (UTC)

Timeless

Just a heads up, this template doesn't render properly in the Timeless skin when using a narrow width (Like with a cell phone). Bawolff (talk) 08:28, 25 January 2025 (UTC)

It seems to have worsened with the TemplateStyles migration in Special:Diff/1270301621, in particular the td {text-align: center} rule. Although even before that, the notations are still off. – SD0001 (talk) 12:24, 25 January 2025 (UTC)

 Fixed the regression in Special:Diff/1271734817. Something still needs to be done about the table wanting to occupy the full width, causing the top and bottom notations to be misaligned and the right-side notations to be far away from the board. – SD0001 (talk) 12:36, 25 January 2025 (UTC)

The styles Timeless adds to .thumbinner at low widths are causing the mess. – SD0001 (talk) 12:42, 25 January 2025 (UTC)

I'm pretty certain you know this, but i'll say it anyway: it is very much possible to add css rules which only affect a specific skin, by plugging .skin-<skin-name> as part of the rule's selector, so it should be possible to amend/override any skin-specific rule in a way that will not affect and will not harm the display in other skins.

Peace - קיפודנחש (aka kipod) (talk) 15:35, 25 January 2025 (UTC)