Wikipedia talk:XFDcloser/Archive 5

Archive 1

←

Archive 3

Archive 4

Archive 5

Archive 6

Beta: RfD error

When closing Wikipedia:Redirects for discussion/Log/2021 January 2#Akira (2009 film), I got the below error and had to add the talk page template manually.

TypeError: date.getUTCDate is not a function error: could not edit page Talk:Akira (2009 film)

fwiw, this followed a pop-up indicating that adding the Old RfD template would overwrite a redirect, though apparently Talk:Akira (2009 film) was not a redirect? It also threw an error rather than passing me the template code to add myself.

Not sure if related, but XFDC also didn't redirect to the section I specified in the form Akira (planned film)#Film rights and conception. Instead it just dropped the section and redirected to the article itself. czar 21:37, 2 January 2021 (UTC)

@Czar:  Fixed both of these issues are now. They weren't actually related, just both happened to affect RfD closes. Regarding It also threw an error rather than passing me the template code to add myself – that's because the error occurred while trying to create the wikitext (template code) for the talk page. - Evad37 [talk] 09:15, 20 January 2021 (UTC)

{{resolved}}

Beta: Unlinker struggles with anchor tag in section heading

{{resolved}}

Unlinking after deleting an article and got a prompt to process a bulleted link in the section "List: LA}}LA Giltinis", referring to List of 2020–21 Major League Rugby transfers § LA Giltinis but struggling with the section heading, which contains an anchor tag: =={{anchor|LA}}LA Giltinis== czar 21:50, 25 December 2020 (UTC)

 Fixed - Evad37 [talk] 15:55, 21 January 2021 (UTC)

Beta: Minimize jiggle

{{resolved}}

Both when loading the closer on the daily AfD page and after the AfD closes, I'm losing my place often with the beta when I generally want to refer to the discussion I was reading. There appears to be some page resituating when the closer is first loaded. And when the AfD is closed, v3 had more visual indication of the closed action, like it was easier to tell which one I just closed and where, if I scrolled through the page and looked at a glance. If there was some way to change the background of the section or otherwise indicate which discussions have been addressed, would help contextualize the change. czar 21:50, 25 December 2020 (UTC)

@Czar: The "jiggle" effect should now be prevented, most of the time, when dialogs open and close. - Evad37 [talk] 03:10, 22 January 2021 (UTC)

Closed/relisted discussions are now styled: the heading will be struck-through, and the discussion text will have 50% opacity. - Evad37 [talk] 04:52, 23 January 2021 (UTC)

Beta: Soft delete rationale

{{resolved}}

It would be great if the beta XFDcloser defaulted to using Wikipedia:XFDcloser/Soft deletion rationale when closing as 'soft delete' Eddie891 ^Talk _Work 17:55, 16 January 2021 (UTC)

Speaking of soft delete, could we please get soft deletion enabled natively for non admins at TfD (section above)? I did write the code patch somewhere above. I’m a bit lazy to select delete and type it in :P ProcrastinatingReader (talk) 18:17, 16 January 2021 (UTC)

@Eddie891:  Fixed - Evad37 [talk] 15:56, 21 January 2021 (UTC)

Beta: Minor things

{{resolved}}

1. Typo "Take care to avoid innapropriate non-administrator closes" (should be "inappropriate"). Though, I find the whole thing a bit distracting personally. Not sure if it's helpful. Probably more of a problem at AfD than at other deletion venues. At the very least, not sure that it needs to be a dropdown, as the hidden message is just as long as the collapse header.
2. When clicking "preferences" the top menu still says "Cancel" on the top left, but clicking the button takes you back. It should probably say "Back".
3. Go to a TfD, click to close, choose "no consensus" or "keep" and then click "Next" to reach the "Result options [holding cell etc]" menu. There's very little margin on the bottom of the oo-ui-fieldLayout-body, looks slightly strange.

ProcrastinatingReader (talk) 13:23, 23 January 2021 (UTC)

Fixed the typo/word choice for #1/#2. With the other stuff, the NAC warning is supposed to be at least somewhat distracting, so that users actually notice it. Though perhaps it can be something that users are able to dismiss, rather than showing up every time. And getting the height of OOUI windows to be "just right" is actually surprisingly difficult; I'll have to take another look (I think I might need to change some existing margins to paddings.) - Evad37 [talk] 17:44, 23 January 2021 (UTC)

@ProcrastinatingReader: The sizing of dialogs (#3) should be better now - Evad37 [talk] 11:54, 24 January 2021 (UTC)

Weird Notice

Received this in my watchlist:

Mai Minokoshi‎ diffhist -4‎ Spartaz talk contribs Removing link(s): Wikipedia:Articles for deletion/Cinema Today closed as delete (XFDcloser) rollback

Doesn't make sense, as one article has nothing to do with the other. Regards, GenQuest ^{"Talk to Me"} 07:42, 7 June 2020 (UTC)

Striking. They're both AfDs. Now I get it. Thanks. — Preceding unsigned comment added by GenQuest (talk • contribs) 08:11, 7 June 2020 (UTC)

{{User:ClueBot III/ArchiveNow}}

Spam

I keep getting spammed by this entity with a pop-up ad that says "Hey its now a gadget, here's how to enable that". Well I did that, and the ad keeps popping up anyway. What's more, there's not even an X to close the pop-up window, and I haven't figured out a way to do that -- I have to leave the page, which impacts my productivity. Is there any way to make this stop? Herostratus (talk) 14:35, 21 June 2020 (UTC)

Herostratus, you also need to remove (or comment out) the call to User:Mr.Z-man/closeAFD2.js in your vector.js, since it's a redirect to the old script. Primefac (talk) 14:44, 21 June 2020 (UTC)

Alright. But perhaps the pop-up could say that. Herostratus (talk) 14:46, 21 June 2020 (UTC)

{{User:ClueBot III/ArchiveNow}}

Beta: Auto-changed the assessed class when closing as redirect

When closing as 'redirect', it would be cool if the tool auto-changed the assessed class to 'redirect'. Just a thought. Eddie891 ^Talk _Work 23:05, 17 November 2020 (UTC)

{{User:ClueBot III/ArchiveNow}} Archiving as this is already listed in the "Possible future features" box at the top of the page. - Evad37 [talk] 03:08, 26 January 2021 (UTC)

Beta: Multiple instances

{{resolved}}

In the past, I've been able to close multiple AfDs at once, which is especially useful when one is taking a while to unlink. Doesn't look like a second instance loads in v4. czar 21:50, 25 December 2020 (UTC)

@Czar:  Done, you can now open multiple instances. This wasn't actually as hard as I though it might be - Evad37 [talk] 04:53, 23 January 2021 (UTC)

Watchlist

{{resolved}}

When closing an AfD, the discussion, the article, and any articles edited to remove backlinks are automatically added to my watchlist because I automatically watchlist articles that I edit. This adds large numbers of articles in which I am not interested at all to my watchlist and I have to spend a lot of time to weed them out. Would it be possible to have an option (like Twinkle does) where users can specify whether or not they want edited articles to be added to their watchlists (regardless of which options they have specified for their watchlists)? Thanks. --Randykitty (talk) 16:49, 16 June 2019 (UTC)

Adding stuff to watchlist?

This is something I've seen often. Sometimes, when I close the AfDs as keep or merge, the script adds the articles to my watchlist automatically. This is probably a bug? --Tone 08:59, 26 November 2019 (UTC)

Any comments on this one? I noticed it is happening again. --Tone 18:13, 15 December 2019 (UTC)

As Randykitty mentions above, if you have "Add pages and files I edit to my watchlist" enabled in Special:Preferences, then any pages edited using XFDcloser will be added to your watchlist. To allow users to control what XFDcloser does, I really need to implement preferences for XFDcloser. Which is something I'm looking at doing, along with modernising/improving the UI, like I recently did for WP:RATER. - Evad37 [talk] 01:45, 16 December 2019 (UTC)

Ok, thanks! --Tone 13:23, 16 December 2019 (UTC)

Rename option for CfD

{{resolved}}

Hi, I was wondering if it's possible to add a rename option to the possible default results. This would be equivilent to using the custom option with the text "Rename". ‑‑Trialpears (talk) 23:04, 4 November 2019 (UTC)

 Acknowledged. Will add this in the next major version, when I redo the interface. - Evad37 [talk] 02:54, 19 December 2019 (UTC)

Log summary change request

{{resolved}}

I'd like:

G8: Talk page of a deleted page. (XFDcloser)

Delete redirect: Wikipedia:Articles for deletion/Fat (song) closed as delete (XFDcloser)

to both be changed either to

G8: Wikipedia:Articles for deletion/Fat (song) closed as delete (XFDcloser)

or

G8: Wikipedia:Articles for deletion/Fat (song) (XFDcloser)

Reason: more explanatory and word-flowy. Also we don't put a period after deleting a talk page when the associated page is deleted per PROD/CSD, and we should explain what reason to delete redirects AFD or not, not bring up what is already happening in our eyes. (Disclaimer: Fat (song) is a placeholder and that AFD is actually a run-of-the-mill April Fools joke. ミラP 04:13, 26 December 2019 (UTC)

@Miraclepine: This will be fixed in the next major version of XFDcloser. Some indication that a page was a redirect should still be left in the log, as once a redirect has been deleted and is a redlink there is no other way to know it was a redirect (apart from admins viewing deleted revisions). Perhaps
     G8 (redirect): Wikipedia:Articles for deletion/Fat (song) closed as delete (XFDcloser)
unless anyone has a better idea. - Evad37 [talk] 07:48, 13 April 2020 (UTC)

Automated actions at CfD

{{resolved}}

I know this has been discussed before somewhere, but I just couldn't find the discussion. Doing the usually automated actions of removing nom-templates and adding {{old cfd}} takes quite a lot of time and really should be automated here as well. It looks like a lot of ground work is done for these features with old cfd formatting and nom-template regexs appearing in the source code so is there and I don't really see anything that different about CfD compared to other venues in this area. What would happen if the code handling CfD in basic mode was removed? --Trialpears (talk) 21:44, 11 July 2020 (UTC)

I just want to say that I'm so happy that this is on the agenda for 4.0! It will make such a huge difference and will likely have a significant impact on the CfD backlog. --Trialpears (talk) 23:05, 20 January 2021 (UTC)

A little bug: "{{subst:^|<strong>}}" showing up inside references

{{resolved}}

I don't quite see what that void subst-ing is being used for in this script, but since subst-ing doesn't work inside references it results in this string appearing in articles, see here and here. Not a very common problem, I've just fixed about 20 instances of this, but maybe this can be avoided. – Thjarkur (talk) 16:44, 27 July 2020 (UTC)

 Acknowledged. That's the result of a hack I used during the backlink removal process/dialogs. It's supposed to disappear when saved, except I forgot that substitution doesn't work within refs... I'll have to make the script do a bit of cleanup before saving. - Evad37 [talk] 01:18, 31 August 2020 (UTC)

Fixed in Beta version - Evad37 [talk] 15:55, 21 January 2021 (UTC)

Cannot run this any more

{{resolved}} In my More tab XFDC Prefs appears (and I can access those), but I can no longer see/use the tool. I have not knowingly changed anything. Thoughts, please? Ping me on answers, or I may miss it. Fiddle^Timtrent Faddle^Talk to me 11:37, 20 June 2021 (UTC)

It's possible its use may now be restricted to admins, of which I am not one Fiddle^Timtrent Faddle^Talk to me 11:58, 20 June 2021 (UTC)

@Evad37, are you able to offer advice, please? Fiddle^Timtrent Faddle^Talk to me 11:03, 23 June 2021 (UTC)

Whatever it is, I still cannot use the tool. Now it's not urgent, because I close very few discussions, but I'd love to know what the issue might be, please? Fiddle^Timtrent Faddle^Talk to me 09:31, 30 June 2021 (UTC)

@Primefac, you seem knowledgable here. Any thoughts, please? Fiddle^Timtrent Faddle^Talk to me 21:32, 20 July 2021 (UTC)

Genuinely can't think of a reason other than potentially something browser-related, as I'm seeing a fair number of NAC/XFDC closes, and no one else has commented. Have you tried a different browser? Primefac (talk) 22:48, 20 July 2021 (UTC)

@Timtrent A couple of things to try: 1) Open up the javascript console on your browser and see if there's anything useful logged. 2) Open an incognito window on Chrome (Private window on Firefox or Safari), login to your wiki account, and see if you still get the problem there. -- RoySmith (talk) 23:04, 20 July 2021 (UTC)

I wonder if it's also a mismatch between the Gadget and user scripts - is XFDC still listed in your user script location of choice? Primefac (talk) 23:05, 20 July 2021 (UTC)

@RoySmith@RoySmith I've tried Safari, my usual browser, and Opera with and without a private window in each. IN all four windows the More tab has only XFDC Prefs in the drop down.

My user script location has very little in it:

Extended content

/* User:Zhaofeng Li/Reflinks.js */ importScript( 'User:Zhaofeng Li/Reflinks.js' );// Backlink: User:Zhaofeng Li/Reflinks.js /*importScript( 'User:Enterprisey/reply-link.js' ); // Backlink: User:Enterprisey/reply-link.js*/ importScript( 'User:Evad37/MoveToDraft.js' ); // Backlink: User:Evad37/MoveToDraft importScript( 'User:Enterprisey/cv-revdel.js' ); // Backlink: User:Enterprisey/cv-revdel.js importScript('User:Awesome Aasim/xfdvote.js'); // Backlink: User:Awesome Aasim/xfdvote.js importScript('user:Qwertyytrewqqwerty/DisamAssist.js'); // Backlink: user:Qwertyytrewqqwerty/DisamAssist.js MY Javascript console says [Warning] Use of "addPortletLink" is deprecated. Use mw.util.addPortletLink instead (Draft:China_COVID-19_cover-up, line 682) [Warning] You installed the userscript User:Smith609/toolbox.js (index.php, line 2) It is no longer working and you should uninstall it. [Info] (index.php, line 63) == CVD bug report for Wikipedia:Miscellany_for_deletion/Draft:China_COVID-19_cover-up by Timtrent == Timtrent (talk · contribs · central auth · count · email) (usergroups) loaded Wikipedia:Miscellany for deletion/Draft:China COVID-19 cover-up at 06:19:48, July 21, 2021 (UTC). Timtrent is only opening all links using copyvios.The script found the following 8 link(s) and filtered out 0 duplicate(s) and 4 invalid link(s). This left the 4 URL(s) listed below. Links and URLs returned by script Links https://thebrain.mcgill.ca/flash/d/d_05/d_05_s/d_05_s_her/d_05_s_her.html https://news.cgtn.com/news/2019-12-31/Authorities-begin-testing-after-pneumonia-cases-in-central-China-MRPvtFbCve/index.html http://en.wiki.x.io/w/index.php?title=Talk:COVID-19_misinformation_by_China&diff=1027791664&oldid=1007546148 http://en.wiki.x.io/w/index.php?title=Special%3ALog&page=Draft%3AChina+COVID-19+cover-up http://en.wiki.x.io/w/index.php?title=Draft:China_COVID-19_cover-up&action=watch http://en.wiki.x.io/w/index.php?title=COVID-19_misinformation_by_China&diff=1030421132&oldid=1030409188&diffmode=source https://apnews.com/article/united-nations-coronavirus-pandemic-china-only-on-ap-bats-24fbadc58cee3a40bca2ddf7a14d2955 http://tv.cctv.com/2019/12/31/VIDE9N8qRty36PkLirFVxMW6191231.shtml URLs http://tv.cctv.com/2019/12/31/VIDE9N8qRty36PkLirFVxMW6191231.shtml https://apnews.com/article/united-nations-coronavirus-pandemic-china-only-on-ap-bats-24fbadc58cee3a40bca2ddf7a14d2955 https://news.cgtn.com/news/2019-12-31/Authorities-begin-testing-after-pneumonia-cases-in-central-China-MRPvtFbCve/index.html https://thebrain.mcgill.ca/flash/d/d_05/d_05_s/d_05_s_her/d_05_s_her.html

The whole thing is way past my technical know how Fiddle^Timtrent Faddle^Talk to me 06:22, 21 July 2021 (UTC)

@Timtrent I don't see anything obvious in the console output. The fact that you get the same behavior in different browsers and/or private mode rules out things like browser-side caching or cookies. I just enabled XFDCloser on a non-admin account of mine (RoySmith-testing), and it worked fine there, so that rules out "you need to be an admin".

The next thing I tried was copying User:Timtrent/common.js to User:RoySmith-testing/common.js. I was fully expecting things to fail at this point, but to my astonishment, it still worked fine. So, I'm stumped. There's obviously something about the state of your account that's not stored in browser-side persistent state (i.e. cache and cookies), nor in common.js. Is it possible you've got some additional javascript (vector.js, etc) that might be loading? The only other thing I can think of is maybe you've got some other option set in your preferences (perhaps another gadget?) that's interacting badly with XFDCloser?

I don't know how far you want to go down the rathole, but the next thing I would suggest is you create another account (it'll need to be extended-confirmed to enable the gadget, but I'll be happy to anoint it for you) and step-by-step recreate your preferences to see when (if?) it stops working. Of course, put a note on the new account's user page so it doesn't get whacked as a sock. -- RoySmith (talk) 11:48, 21 July 2021 (UTC)

@RoySmith I'll give it a hard stare again in a few minutes. What if I untick preferences and see if it ever starts working? I'll look for other sub page, too Fiddle^Timtrent Faddle^Talk to me 12:34, 21 July 2021 (UTC)

@RoySmith I have the following .js pages

• User:Timtrent/monobook.js
• User:Timtrent/twinkleoptions.js
• User:Timtrent/vector.js

The significance of the various .js files escapes me and I am only on distant terms with their contents, like meeting an estranged aunt

I can list my preferences if this becomes useful Fiddle^Timtrent Faddle^Talk to me 12:48, 21 July 2021 (UTC)

I copied all those over to my testing account, and still can't get it to fail. So, at this point, I have no clue what's going on. Wish I could be more useful.

One general suggestion is to get rid of your monobook.js and vector.js. Those are skin-specific scripts. The idea is that if you're using monobook, you get common.js + monobook.js, and if you're using vector, you get common.js + vector.js. The vast majority of people only use a single skin, so just putting whatever you need into common.js and getting rid of the others simplifies things. That won't fix whatever's going on here, but it'll be one less complication in an already over-complicated world.

I noticed you've already got User:Fiddle Faddle, so see if this works from that account. As for unticking preferences, that's not an unreasonable way to attack this, but it has the problem that unless you're very methodical about recording what you've changed, it'll be difficult to get things back to exactly the way they were before. -- RoySmith (talk) 14:38, 21 July 2021 (UTC)

I appreciate your help @RoySmith I'll work steadily through it. Screenshots are a way to go. I'll also see it if it works from @Fiddle Faddle. Does that account have the correct permissions? I try never to use it

The two .js files are ether already deleted or up for CSD Fiddle^Timtrent Faddle^Talk to me 15:41, 21 July 2021 (UTC)

I've just granted Extended Confirmed to User:Fiddle Faddle -- RoySmith (talk) 15:51, 21 July 2021 (UTC)

@RoySmith: This is from my FF account. It only has commons.js. In prefs I asked it to restore all default settings. I went to look at Wikipedia:Miscellany for deletion/Draft:China COVID-19 cover-up which I have been using throughout to see if it will work! (I know I am not entitled to close it because I have participated imn ity in my real life account. I am not there to take any action), and the FF More tab also only shows XFDC Prefs. I'm happy privately by email to share the FF login credentials with you for diagnostic purposes if that is allowed under our rules and if you are happy to play further. Fiddle Faddle (talk) 16:22, 21 July 2021 (UTC)

obvs, I did tick the XFD Closer tool!!! Fiddle^Timtrent Faddle^Talk to me 16:29, 21 July 2021 (UTC)

No, please don't send me your credentials. That's never a good plan. I'm afraid I'm going to have to bail here. I'm totally out of ideas. -- RoySmith (talk) 17:22, 21 July 2021 (UTC)

@RoySmith I think I will just not close any more deletion discussions. I never closed many, but some were interesting

Isn't it bizarre? Fiddle^Timtrent Faddle^Talk to me 19:39, 21 July 2021 (UTC)

Xfd closer malfunction

{{resolved}} I wish to withdraw my nomination from an AfD. I am trying to use my XFD closer. But the only button I have for this is "xfdc preferences." When I click on that I don't get the box that asks me to choose what kind of close. Instead I see something about enabling Beta version, add edited pages to my watchlist, collapse task warnings if at least:, and collapse task errors if at least. Is the xfd closer malfunctioning or is my particular closer malfunctioning? I am unable to close this AfD using the XfD closer. ---Steve Quinn (talk) 21:01, 10 August 2021 (UTC)

If someone wants to look at the page, here is the AfD [1]. I am not interested in having the AfD closed. I am interested in having my XFD closer work. Thanks. ---Steve Quinn (talk) 21:10, 10 August 2021 (UTC)

Possible duplicate of the issues described in #Cannot run this any more above? Primefac (talk) 21:40, 10 August 2021 (UTC)

@Primefac: Thanks for responding so quickly. I resolved the problem with my un-technical non-expertise. I was reading the above thread entitled "Cannot run this any more." Then I came up with the idea to uncheck the XFD closer in my Gadgets, save it, and then close my browser. Then I reopened my browser, re-checked XFD closer in Gadgets, and saved that. I closed the browser again, came back, and found it working. I am writing all this because maybe it will help someone else in the future. ---Steve Quinn (talk) 22:26, 10 August 2021 (UTC)

I can also reccomend trying a different browser as suggested in the above thread that you and I mentioned, "#Cannot run this any more." ---Steve Quinn (talk) 22:29, 10 August 2021 (UTC)

Hopefully this is a helpful ping. Primefac (talk) 22:41, 10 August 2021 (UTC)

@Primefac A little like when the days of old TV repair man came to repair your set and it decided to work perfectly I have revisited the issue. Thank you for the ping. I decided to check an XfD and the little close things are now present where they were previously absent. I changed nothing. Perhaps some underlying issue changed on my Mac. Thank you for the ping. Fiddle^Timtrent Faddle^Talk to me 08:32, 11 August 2021 (UTC)

Bug report: XfD closer broken

{{resolved}} I can't currently use the script because the text fields for the result and the rationale don't show up. Screenshot: https://imgur.com/a/i6Z1WOW. I'm using the current Chrome browser on Windows 10. Sandstein 11:18, 21 January 2022 (UTC)

Can confirm, does not work on Firefox either (checked both the AFD Sandstein is having issues with as well as a few WP:TFD listings). Primefac (talk) 11:33, 21 January 2022 (UTC)

Just on the off chance that Evad37 isn't paying as much attention as necessary due to the ongoing RFC.... ping! Problems abound. Primefac (talk) 20:37, 21 January 2022 (UTC)

• Can confirm this gadget is broken on WP:RFD; the "Rationale" and "Preview" options do not work. Tried on Safari and Chrome. Steel1943 (talk) 18:38, 21 January 2022 (UTC)
• As a workaround, I am using it to close, then adding any additional text as a follow-up edit. This seems to work fine and avoids the need to apply the close templates manually. --RL0919 (talk) 20:32, 21 January 2022 (UTC)

  Same. The first time I thought I misclicked, which I have been known to do. But it is persisting. AfD on Mac, no os updates since it last worked. Broken in both Chrome and Firefox. Star Mississippi 23:23, 21 January 2022 (UTC) ETA example if helpful. Star Mississippi 03:06, 22 January 2022 (UTC)

  I've noticed this too. It doesn't seem to be limited to XfDcloser: the text fields for adding captions to images in VisualEditor have vanished as well. The problem's onset did seem to coincide with a certain day of the week... Extraordinary Writ (talk) 00:47, 22 January 2022 (UTC)

Investigating now. My suspicion is a breaking change to mw:OOUI. (Please continue to ping me and/or leave talk page messages when reporting urgent issues, or if I'm taking a long time to reply. My watchlist is too big to be useful given that I'm less active then I used to be.) - Evad37 [talk] 01:13, 22 January 2022 (UTC)

 Fixed - Evad37 [talk] 03:09, 22 January 2022 (UTC)

Many thanks. Sounds like a typical THURSDAY snafu. Primefac (talk) 15:12, 22 January 2022 (UTC)

Query

{{resolved}} I'm seeing an admin use XFDcloser to remove links from deleted articles that are not deleted through XFD discussions. How is that possible? I'd like to find a tool to use to do that but reading over the tool page, I don't see how XFDcloser can be used to remove links from articles deleted through PROD or CSD. I'd appreciate any information anyone familiar with the tool can provide. Many thanks. Liz ^{Read! Talk!} 00:34, 2 May 2022 (UTC)

Liz, Twinkle can remove backlinks. (I don't close enough AFDs to say if it's possible with XFDCloser. It is not possible when closing a TFD to remove backlinks.) Izno (talk) 01:39, 27 June 2022 (UTC)

Though, if you look a couple sections up, there is a strong implication that XFDCloser can remove backlinks. Izno (talk) 01:39, 27 June 2022 (UTC)

@Liz, User:Evad37/Xunlink is what you want—it works on any article. It's built on the automatic unlinking that happens after XFDcloser's AfD closures. And it has smarter detection rules than Twinkle's. czar 01:47, 27 June 2022 (UTC)

Belated thank yous to Izno and Czar. I appreciate the suggestions! Liz ^{Read! Talk!} 22:56, 11 August 2022 (UTC)

Bug: XFDcloser messes up talk page redirects

{{resolved}} See this. It should have an exception for this. _{Piotr Konieczny aka Prokonsul Piotrus| reply here} 02:59, 18 August 2022 (UTC)

That's not a bug. XFDC asks when there is a talk page redirect whether or not to overwrite the redirect with the old RfD template. -- Tavix ^(talk) 03:04, 18 August 2022 (UTC)

Problem with XFDcloser and bundled nominations at AFD

{{resolved}} Hello, all,

I'm having no luck with XFDcloser closing AFD nominations where there are a lot of articles bundled together. These have been nominations proposed by different editors so I know it isn't just one person not understanding how to do this. XFDcloser deleted the primary, first article mentioned in the nomination and ignores all of the articles listed (sometimes they are hatted, sometimes they are not). This requires a manual deletion of sometimes dozens of separate articles which can be a little time-consuming. Or, you can make a huge blunder, like I did last night, and try to batch delete them using Twinkle and end up with a huge mess to clean up. That's a mistake you only make once.

What do you think might be the problem here? Is it XFDcloser or is it the way that the bundled nomination is formatted that XFDcloser can't "see" all of the other articles that are proposed for deletion? I've discussed this with the nominators and maybe there just has to be a better explanation in the instructions for bundled nominations. Thanks for any ideas you can offer. Liz ^{Read! Talk!} 21:27, 21 August 2022 (UTC)

Can you link some recent examples? The most common issue I've found is that bundled noms are not detected as bundled unless the secondary articles use the {{la}} template. I usually make this correction and then refresh the nomination to make sure XFDC counts all affected pages in its counter before continuing. czar 23:15, 21 August 2022 (UTC)

I am going to second Czar on this one - XFDC will only flag the pages that are actually listed properly (this happens on TFD nominations all the time). The "whoops" mentioned above occurred due to Wikipedia:Articles for deletion/Mazraeh-ye Tahqiqati Tutun; each of the hatted wikilinks would need to be listed in {{la}} in order for XFDC to pick them up. Sometimes it's easier to follow Czar's method and convert them, I will often copy the entire list to a subpage so that I can use Twinkle's d-batch functionality (as mentioned on your talk page in the related thread). Primefac (talk) 12:48, 22 August 2022 (UTC)

Daily deletion log pages not loading correctly

{{resolved}} Hello, XFDCloser

The daily deletion log pages are not loading correctly. But it's not a good sign though that apparently the maintainer, Evad37, is inactive. There should really be a backup contact person as when the systems fail, they seem to fail spectacularly and affect the work of a lot of editors. Help! Liz ^{Read! Talk!} 01:29, 1 January 2023 (UTC)

not loading correctly - what do you mean? Primefac (talk) 13:08, 1 January 2023 (UTC)

Hello, Primefac,

I was just coming to remove this query from the page. I tried a lot of different solutions that were suggested at VPT (adding/removing scripts from .js page, working with Preferences, etc.) and it turns out that "Hide/Show closed discussions" button disappeard from the daily deletion log pages so all of the closed discussions were hidden and there was no way to get them to show back up because there was no longer any button to toggle. I rebooted, cleared out my cache and cookies and, for some reason, the button came back into view. But because my problem appeared at exactly the time it changed from 2022 UTC to 2023 UTC, I thought it might be a system problem but it turns out it was just a problem with my browser. Liz ^{Read! Talk!} 02:13, 2 January 2023 (UTC)

Good to know! Primefac (talk) 08:38, 2 January 2023 (UTC)

Add a delete button

{{resolved}} Add a delete button when closing a discussion, instead of having to add manually via the custom button. Preferably put it after the third tab/button, "soft redirect". Qwerty284651 (talk) 02:58, 2 February 2023 (UTC)

Uh... XFDC does have a delete option? Primefac (talk) 20:57, 2 February 2023 (UTC)

It doesn't render for non-admins. But yeah, Qwerty appears to not know that deletion is an admin-only action. _signed, Rosguill ^talk 21:47, 2 February 2023 (UTC)

I've closed loads of CfDs as delete. But outside of CfD, it's probably unhelpful. — Qwerfjkltalk 21:51, 2 February 2023 (UTC)

Thanks for the input you, guys. Qwerty284651 (talk) 22:04, 2 February 2023 (UTC)

Missing "soft delete" button?

{{resolved}} I have the ability to close as a "regular" delete, but no option to soft-delete. Running on Chrome. Joyous! | Talk 19:59, 12 February 2023 (UTC)

Soft deletion is (should be) an additional option checked after selecting deletion as the option. Do you not see this option at all? What flavour of XFD are you attempting to use it on? Primefac (talk) 12:24, 13 February 2023 (UTC)

Well. Heck. It's sitting right there. I was looking for it among the options before selecting "delete." I've closed many a discussion with a delete, and somehow managed not to see those checkboxes. Thanks for your help! (and pardon me while I slink away to hide my red face) Joyous! | Talk 17:13, 13 February 2023 (UTC)

Super-easy to miss the non-obvious :-) Just glad it was an easy fix and not something broken! Primefac (talk) 20:09, 13 February 2023 (UTC)

Archive 1

←

Archive 3

Archive 4

Archive 5

Archive 6

Loading problem

Tracked in Phabricator
Task T359014

I've opened multiple AfD pages in the last 15 minutes, using two different browsers on different devices, but XFDCloser doesn't appear to be loading on any of them. No close/relist links, and or the option to show/not show closed discussions. I've not had this problem previously. RL0919 (talk) 06:59, 22 January 2024 (UTC)

RL0919, I had this problem on my tablet, and hacked together this script, which just adds a link to load XFDCloser;

mw.util.addPortletLink ( 'p-tb', "javascript:importScript('MediaWiki:Gadget-XFDcloser-core.js')", 'Load XFDCloser', 'pt-loadxfdc', 'Manually loads XFDCloser');

— Qwerfjkltalk 16:26, 22 January 2024 (UTC)

Unable to reproduce on Vector 2010. Are you two getting any WP:CONSOLEERRORs? Which skin is being used? –Novem Linguae (talk) 18:44, 22 January 2024 (UTC)

Novem Linguae, I don't get the bug on my computer, but I believe the error was some missing dependency (unable to inherit Origin or something). I'll see if I can reproduce the error and give the actual error message. — Qwerfjkltalk 19:02, 23 January 2024 (UTC)

@Novem Linguae: I am using Vector 2022.The most relevant console error is probably this one: "Parse error: Unexpected: ( on ext.gadget.XFDcloser-core-script-0.js:24 line 21". Qwerfjkl's load button hack does work for me, even though the console error still appears. --RL0919 (talk) 17:04, 24 January 2024 (UTC)

A syntax error would normally break the whole file for everyone, so really weird that it's just happening to you. Also, MediaWiki:Gadget-XFDcloser-core.js is minified, which makes debugging harder. –Novem Linguae (talk) 18:24, 24 January 2024 (UTC)

I think it is happening to me as well. I'm using the Vector legacy (2010) skin. XFDcloser is not loading in any of the AfDs. ❯❯❯ Raydann^(Talk) 15:52, 25 January 2024 (UTC)

Novem Linguae, I suspect it's a script conflict. @RL0919, @Raydann, what happens if you blank your .js pages? — Qwerfjkltalk 16:14, 25 January 2024 (UTC)

Problem still persists after blanking my common.js ❯❯❯ Raydann^(Talk) 16:23, 25 January 2024 (UTC)

I previously tried blanking both common.js and vector.js, but this had no apparent impact on the problem. --RL0919 (talk) 17:25, 25 January 2024 (UTC)

I've been getting this issue on Vector 2010 too czar 03:59, 26 January 2024 (UTC)

But today it's working fine czar 22:59, 26 January 2024 (UTC)

I've been having this problem for the last twenty-four hours or so with Vector 2010. It works just fine with the other skins (even MonoBook!), interestingly. Extraordinary Writ (talk) 00:39, 28 January 2024 (UTC)

And now working again. Extraordinary Writ (talk) 23:30, 28 January 2024 (UTC)

Yes, for me it works in every skin except Vector legacy 2010. ❯❯❯ Raydann^(Talk) 20:11, 29 January 2024 (UTC)

Novem Linguae, I'm getting the following error:

Uncaught Error: inheritClass: Origin is not a function (actually undefined)
    at OO inheritClass (oojs.js:85:9)
    at 164.../../globals (<anonymous>:21:126600)
    at o (<anonymous>:21:254)
    at <anonymous>:21:288
    at 170.../../globals (<anonymous>:21:145875)
    at o (<anonymous>:21:254)
    at <anonymous>:21:288
    at 225.../../globals (<anonymous>:21:469338)
    at o (<anonymous>:21:254)
    at <anonymous>:21:288

But I have a more serious error: Parse error: Unexpected: ( on line 21
which means I cannot run the normal version of XFDCloser at all. THe beta version still works. — Qwerfjkltalk 21:35, 27 January 2024 (UTC)

I'm getting a similar error, using Monobook on Chrome 121.0.6167.139 for Mac (arm64). Same on Edge 121.0.2277.98.

Parse error: Unexpected: ( on line 21
css @ ext.gadget.XFDcloser-core-beta-script-0.js:24
runScript @ startup.js:1275
(anonymous) @ startup.js:1353
flushCssBuffer @ startup.js:606
requestAnimationFrame (async)
addEmbeddedCSS @ startup.js:637
execute @ startup.js:1367
doPropagation @ startup.js:757
requestIdleCallback (async)
setAndPropagate @ startup.js:830
impl @ startup.js:2009
(anonymous) @ load.php?lang=en&modules=ext.gadget.XFDcloser-core-beta&skin=monobook&version=1t9io:1

-The Wordsmith^{Talk to me} 19:01, 6 February 2024 (UTC)

The Wordsmith, try switching to the beta script. — Qwerfjkltalk 19:08, 6 February 2024 (UTC)

I'm not seeing an option to switch to the beta script, where is it located? The Wordsmith^{Talk to me} 19:37, 6 February 2024 (UTC)

Update: I used the addPortletLink above, and was able to make it load. It turns out I was already on Beta, once I could load my Preferences. Converting back to the standard version, reloading and purging my cache got it to load consistently on that AFD and several others. I tried to reproduce the issue by re-enabling the beta version and reloading the page, and again it stopped loading on AFDs. Repeating the process of going back to standard version and reloading fixed it again. For me, it seems like the problem is with the beta version only. The Wordsmith^{Talk to me} 20:29, 6 February 2024 (UTC)

Strange, I have the opposite problem. — Qwerfjkltalk 21:27, 6 February 2024 (UTC)

I am also having this error on vector-2022 and @Qwerfjkl's hack isn't working. The script works perfectly fine without Q's hack on all of the other skins.

I am also getting the following error on vector-2022:

Parse error: Unexpected: ( on line 21 ext.gadget.XFDcloser-core-beta-script-0.js:24:1
<anonymous>ext.gadget.XFDcloser-core-beta-script-0.js:24
runScriptstartup.js:1275
cssHandlestartup.js:1353
flushCssBufferstartup.js:606

Pinging @Novem Linguae as well. voorts (talk/contributions) 19:59, 19 February 2024 (UTC)

Not sure how good you are with DevTools, but if that happens again, can you try going to the location of the error and copy/paste the code that is causing the parse error? This would either involve clicking on the line number in the stack trace, or going to the network tab and finding ext.gadget.XFDcloser-core-beta-script-0.js and taking a peek at its contents. Somewhere else on this page we theorized that a mediawiki error message was being sent instead of the program code for XFDCloser, causing this parse error. I think if we are able to read this mediawiki error message, we can do further debugging. –Novem Linguae (talk) 20:11, 19 February 2024 (UTC)

@Novem Linguae: Is this what you're looking for:

Extended content
(Large block of minified code, removed as not relevant)

voorts (talk/contributions) 20:18, 19 February 2024 (UTC)

@Novem Linguae: Upon further inspection, although my error message says line 21, it links to http://en.wiki.x.io/w/virtual-resource/ext.gadget.XFDcloser-core-beta-script-0.js:24, and when I click through, it goes to line 24 of the beta script (which I copied to the extended content above), For the non-beta script, here's line 21: /* jshint esversion: 5, esnext:false, laxbreak: true, undef: true, eqnull: true, maxerr: 3000 */ and here's line 24: (function(){ voorts (talk/contributions) 23:38, 19 February 2024 (UTC)

@Novem Linguae: any word on this? Thanks, voorts (talk/contributions) 22:35, 3 March 2024 (UTC)

This looks like it's not easily reproducible, making it a class of bug that will be really hard to fix. Based on the comments so far, I think SD0001's theory about Peast validation sometimes failing and then the error message getting cached is the most likely explanation given so far. Has anyone made a Phabricator ticket about this yet? Problems with Peast should get a Phabricator ticket. I guess tag the new Phab ticket with MediaWiki-ResourceLoader? Perhaps SD0001 would be willing to make the ticket?

Also voorts, can you state how often this is happening for you? –Novem Linguae (talk) 01:11, 4 March 2024 (UTC)

It's occurring consistently. The links haven't shown up at AfD, CfD, FfD, MfD, or TfD discussions for me for a while. voorts (talk/contributions) 01:54, 4 March 2024 (UTC)

phab:T359014. – SD0001 (talk) 06:22, 4 March 2024 (UTC)

It came back for me again too, I'm able to gather some more data. For me, it links to [2], and the text seems to be the normal gadget code (where everything is on line 21) but with a 3-line comment at the top containing the gadget name MediaWiki:Gadget-XFDcloser-core-beta.js. Clicking on the source mapping, it takes me to load.php?lang=en&modules=ext.gadget.XFDcloser-core-beta&skin=monobook&version=1t9io which contains this function:

mw.loader.impl(function() {
    return ["ext.gadget.XFDcloser-core-beta@1svn5", function($, jQuery, require, module) {
        mw.log.error("Parse error: Unexpected: ( on line 21");
    }
    , {
        "css": [".xfdc-status{font-size:small;margin-left:13px;font-weight:normal}.skin-timeless .xfdc-status{font-size:0.98rem}.skin-minerva .xfdc-status{font-size:0.98rem;display:block;margin:-1rem 0 1rem}.xfdc-action{font-weight:normal}.xfdc-action a{cursor:pointer}.xfdc-qc-cancel{cursor:pointer;border:1px solid #777;border-radius:10px;font-weight:bold;font-size:90%;color:#777;padding:0;margin:0 1px} .xfdc-old .xfdc-action{background-color:#c6ffc6}.xfdc-notOld .xfdc-action{background-color:#ffc6c6}.xfdc-unknownAge .xfdc-action{background-color:#ffffc6}.xfdc-notOld.xfdc-relisted .xfdc-action{background-color:#ffe9c6} .xfdc-actioned-heading{text-decoration:line-through double black;opacity:75%}.xfdc-actioned-discussion{opacity:50%} html body.ooui-draggbleWindow-open{position:unset;overflow:unset;margin-right:unset !important; }html body.ooui-draggbleWindow-open .oo-ui-windowManager-modal \u003E .oo-ui-dialog.oo-ui-window-active{position:static;padding:0} html body.ooui-draggbleWindow-open .oo-ui-dialog.oo-ui-window-active \u003E div{z-index:110;transition:all 0.25s ease-out 0s,transform 0s !important}  .oo-ui-textInputWidget.oo-ui-textInputWidget-labelPosition-before.padLeft2em .oo-ui-inputWidget-input{padding-left:2em !important}.oo-ui-textInputWidget.oo-ui-textInputWidget-labelPosition-before.padLeft4em .oo-ui-inputWidget-input{padding-left:4em !important} .xfdc-menuOptionWidget.oo-ui-decoratedOptionWidget{padding:7px 12px} .xfdc-taskItemWidget \u003E .oo-ui-fieldLayout-messages{clear:both} #XFDcloser-showhide{bottom:0;display:block;position:fixed;right:0;z-index:100;padding:5px;box-shadow:0 2px 4px rgba(0,0,0,0.5);background-color:#fef9e6;border:1px solid #aaa;border-radius:5px;font-size:85%}"]
    }];
});
// Saved in localStorage at 2024-02-12T22:09:25.448Z
//# sourceURL=http://en.wiki.x.io/w/load.php?lang=en&modules=ext.gadget.XFDcloser-core-beta&skin=monobook&version=1t9io
//# sourceMappingURL=/w/load.php?lang=en&modules=ext.gadget.XFDcloser-core-beta&skin=monobook&sourcemap=1&version=1t9io

Not sure how helpful this is, but I'll collect any additional data you need. The Wordsmith^{Talk to me} 20:46, 19 February 2024 (UTC)

This code is similar/identical to Nardog's code below, so I think we're on the right track, but I was hoping to get whatever file has the line 21 referred to in Parse error: Unexpected: ( on line 21. That might have an error message that could be further debugged. –Novem Linguae (talk) 23:29, 19 February 2024 (UTC)

I wasn't able to see anything with something strange on line 21, but I suspect it's the XFDCloser script that shows an issue on line 24 (just without that 3-line comment). I exported my console log; I won't paste it on this page for the sake of keeping this discussion readable but I uploaded it here. The Wordsmith^{Talk to me} 01:05, 20 February 2024 (UTC)

Buttons not showing up, "Parse error: Unexpected: ( on line 21" on Vector legacy

Anybody else not seeing "[Close] [quickClose] [Relist]" and getting "Parse error: Unexpected: ( on line 21" in console? Seems to be happening on every XfD page. I tried disabling all gadgets except XFDcloser and still got it. The console says it's coming from ext.gadget.XFDcloser-core-script-0.js:24:1 (not 21!), which is not helpful. Works on every other skin and, worse, in debug mode. Nardog (talk) 17:35, 8 February 2024 (UTC)

Nardog, see #Loading problem, one of the solutions there might help. — Qwerfjkltalk 18:02, 8 February 2024 (UTC)

Oh, sorry for not looking enough. This is such a head scratcher. I can't even figure out what's ultimately emitting the error, or line 21 of what, and we all seem to have different conditions for reproducing it. Nardog (talk) 23:49, 8 February 2024 (UTC)

I tried reproducing it today, exact same conditions but the gadget loaded fine on standard and beta. Very curious. But if I'm looking at MediaWiki:Gadget-XFDcloser-core.js right, its ALL on line 21. The Wordsmith^{Talk to me} 02:41, 9 February 2024 (UTC)

If #Request: turn off minifier is actioned, errors would probably give a more accurate line number. –Novem Linguae (talk) 05:48, 9 February 2024 (UTC)

Ah, the SourceMap source is 3 lines off because it inserts the name of the gadget at the top.

Whether you have enabled beta should not have to do with the culprit because currently the release and beta scripts are completely identical. If it makes a difference it must simply be that it somehow affects the race condition. (And the "Origin is not a function" error above is simply an effect of loading the script directly without the dependencies given in MediaWiki:Gadgets-definition.)

Turns out, the error message is generated by the server-side script validation (ironically the source map was a hindrance to discovering this). http://en.wiki.x.io/w/load.php?lang=en&modules=ext.gadget.XFDcloser-core&skin=vector&version=m2csj, which is where I got the error from, currently returns:

mw.loader.impl(function(){return["ext.gadget.XFDcloser-core@30cwo",function($,jQuery,require,module){mw.log.error("Parse error: Unexpected: ( on line 21");
},{"css":[".xfdc-status{font-size:small;margin-left:13px;font-weight:normal}.skin-timeless .xfdc-status{font-size:0.98rem}.skin-minerva .xfdc-status{font-size:0.98rem;display:block;margin:-1rem 0 1rem}.xfdc-action{font-weight:normal}.xfdc-action a{cursor:pointer}.xfdc-qc-cancel{cursor:pointer;border:1px solid #777;border-radius:10px;font-weight:bold;font-size:90%;color:#777;padding:0;margin:0 1px} .xfdc-old .xfdc-action{background-color:#c6ffc6}.xfdc-notOld .xfdc-action{background-color:#ffc6c6}.xfdc-unknownAge .xfdc-action{background-color:#ffffc6}.xfdc-notOld.xfdc-relisted .xfdc-action{background-color:#ffe9c6} .xfdc-actioned-heading{text-decoration:line-through double black;opacity:75%}.xfdc-actioned-discussion{opacity:50%} html body.ooui-draggbleWindow-open{position:unset;overflow:unset;margin-right:unset !important; }html body.ooui-draggbleWindow-open .oo-ui-windowManager-modal \u003E .oo-ui-dialog.oo-ui-window-active{position:static;padding:0} html body.ooui-draggbleWindow-open .oo-ui-dialog.oo-ui-window-active \u003E div{z-index:110;transition:all 0.25s ease-out 0s,transform 0s !important}  .oo-ui-textInputWidget.oo-ui-textInputWidget-labelPosition-before.padLeft2em .oo-ui-inputWidget-input{padding-left:2em !important}.oo-ui-textInputWidget.oo-ui-textInputWidget-labelPosition-before.padLeft4em .oo-ui-inputWidget-input{padding-left:4em !important} .xfdc-menuOptionWidget.oo-ui-decoratedOptionWidget{padding:7px 12px} .xfdc-taskItemWidget \u003E .oo-ui-fieldLayout-messages{clear:both} #XFDcloser-showhide{bottom:0;display:block;position:fixed;right:0;z-index:100;padding:5px;box-shadow:0 2px 4px rgba(0,0,0,0.5);background-color:#fef9e6;border:1px solid #aaa;border-radius:5px;font-size:85%}"]}];});

But if you change vector to vector-2022 or monobook or remove &version=m2csj, you get the whole script with no errors. This suggests something is wrong with the validation and/or the server caching. @SD0001: Do you have a clue why this is? Nardog (talk) 10:54, 9 February 2024 (UTC)

I was able to reproduce the issue last week but not any more. Even the load.php link you gave is returning the expected output now. The error seems to be due to server-side validation intermittently failing. Once it fails, the result is cached so it fails consistently. Changing the skin or switching to beta changes the context hash or cache key so the failure may go away.

I tried running the Peast validator on the script locally, but it's passing every time. – SD0001 (talk) 11:49, 9 February 2024 (UTC)

Weird, it still returns what I pasted above even if I refresh or go incognito. But I just tried accessing it through a VPN and it did return the expected result. So it may depend on the data center or CDN. Nardog (talk) 12:26, 9 February 2024 (UTC)

Interesting, when I got the error it was on Monobook. I hadn't tried any of the other skins. The Wordsmith^{Talk to me} 16:34, 9 February 2024 (UTC)

Update

I've got good news. phab:T359014 patch is written and merged, and will be deployed soon. This will likely fix this bug. May take a week to deploy though. Feel free to check the phab ticket for updates. –Novem Linguae (talk) 20:12, 6 March 2024 (UTC)

Patch will deploy on Thurs, Mar 14. –Novem Linguae (talk) 23:11, 6 March 2024 (UTC)

Plus possibly another week after that for caches to clear (Thurs, Mar 21), if they don't merge a cache clearing patch before Monday, Mar 11. –Novem Linguae (talk) 09:33, 7 March 2024 (UTC)

Anybody still getting this bug? If not, then the fix probably worked and we should OneClickArchive this section soon :) –Novem Linguae (talk) 19:36, 26 March 2024 (UTC)

I haven't seen it in the last week or so. The Wordsmith^{Talk to me} 21:15, 26 March 2024 (UTC)

It's working for me as well. Thank you and the rest of the phab pholks for fixing this. voorts (talk/contributions) 21:46, 26 March 2024 (UTC)

Bug: [Close] link not appearing.

The [Close] option is not appearing on AfD, CfD, FfD, or TfD discussions for me. I'm using Firefox 122.0.1 (64-bit) to browse, vector-2022 with dark mode, and these userscripts. voorts (talk/contributions) 19:17, 19 February 2024 (UTC)

Voorts, see #Loading problem. — Qwerfjkltalk 19:33, 19 February 2024 (UTC)

XFDcloser causing closed discussions to completely disappear

{{resolved}} I just noticed a new bug with XFDcloser: It now seems that on some pages of RFD where there are closed discussions, XFDcloser Now completely hides some of these discussions. This is quite problematic because it makes it so closed discussions cannot be reviewed; In fact, sometimes, this problem will make it so the evidence of a discussion even existing on that subpage is hard to find, unless one looks through the table of contents (provided one even shows up) or edits the page. Steel1943 (talk) 14:24, 28 April 2024 (UTC)

Could you give an example? Primefac (talk) 14:31, 28 April 2024 (UTC)

@Primefac: Wikipedia:Redirects for discussion/Log/2024 April 7. If you see the issues I described, the issues stopped happening once I disabled XFDcloser and reloaded the page. Steel1943 (talk) 14:53, 28 April 2024 (UTC)

Steel1943, you have no edits to that page. Did you have closed discussions hidden? Primefac (talk) 15:07, 28 April 2024 (UTC)

"Did you have closed discussions hidden?" Yes, and I don't know when I clicked that thing since it's in a really inconspicuous spot. Dang it XFDcloser. Steel1943 (talk) 15:11, 28 April 2024 (UTC)

Yeah, can't argue with that, though glad it's not a proper glitch. Primefac (talk) 15:28, 28 April 2024 (UTC)

Weird preview in close box

I am writing up a close for a TFD, and while writing I used a {{tq}} for a quote. In the preview box it (for some reason) triggers the {{FormattingError}} in the template ("Template:Tq is only for quoting in talk and project pages. Do not use it in actual articles."), but that's only triggered when the template is used in the article space (NS0). Why would this script, when previewing the content, make the template think that it's in the mainspace? If the answer is "who knows" that's totally fine (I can still read what I wrote in the edit box!) but I'm curious is there's a line of code somewhere that might be making the environment think that the preview is in ns0. Primefac (talk) 11:20, 30 August 2021 (UTC)

By default the context page title used for previews is API, which in NS0. XFDC needs to pass the actual page name to the preview API for this error to not occur. – SD0001 (talk) 12:46, 14 September 2021 (UTC)

@Evad37 I opened a PR to fix this at https://github.com/wikimedia-gadgets/xfdcloser/pull/19. Can you take a look? – SD0001 (talk) 12:45, 15 September 2021 (UTC)

The fix for this one will deploy in a couple minutes. {{Resolved}} –Novem Linguae (talk) 11:38, 2 June 2024 (UTC)

Another feature request: WP:INVOLVED warnings.

I close a lot of AfDs and don't always remember if I've commented on them before (which would make me ineligible to close it). I usually search for my signature before closing to make sure, but sometimes I forget to do that. I once (somewhat harshly, which I regret) took somebody to task for closing an AfD they had participated in and it turned out to be exactly the same thing; they had innocently forgotten their earlier involvement. It would be cool if XFDcloser could examine the XfD edit history and note somehow that you've already been involved. -- RoySmith (talk) 15:06, 4 October 2019 (UTC)

@RoySmith: Hey, aren't you supposed to be reading the xfd to determine the consensus before closing it? How would you miss your own !vote if you do that? SD0001 (talk) 07:30, 6 October 2019 (UTC)

Sure, but having this would be a safety feature to prevent accidents. It would also save time; it's annoying to spend time reading through a long discussion, only to find a comment by yourself that you'd long forgotten about. It's not a huge thing, just a "nice to have". -- RoySmith (talk) 14:27, 6 October 2019 (UTC)

I could imagine this happening in a case where there are, say, 5 or more participants who all !vote either "keep" or "delete". Not really necessary here to waste time on reading all arguments in detail, as the outcome is pretty clear. And an admin who does a lot of editing may have forgotten that they already !voted themselves and even though the outcome is clear, it is not appropriate for them in that case to close the AfD. It will be rare, but I can see it happen. --Randykitty (talk) 14:51, 6 October 2019 (UTC)

Sometimes there are AfDs in which all the keep or delete comments are not within policy. We can't close as keep or delete against the consensus vote (as that would be a supervote, given that the relevant policy based argument has not been brought up), but we can leave our own keep/delete comment pointing out the relevant policy so the next admin to come along can do the appropriate thing. We do more than just count the !votes, otherwise a bot could close AfDs. If it's too much of an effort to read all the comments, no worries, just leave it and go to the next AfD. There is no pressure on any of us to close an AfD, and we shouldn't be closing an AfD if we haven't read the arguments. There are some of us who do go though the old AfDs to close the tricky ones that require a lot of reading. I don't mind doing that. Indeed, I do that rather than close the easy ones, as it's the tricky ones that I find more interesting and satisfying. The great thing about this being an open wiki, is that there is a task for everyone, so nobody need feel under pressure to do something they don't want to. SilkTork (talk) 10:29, 28 November 2019 (UTC)

Wikipedia:Articles for deletion/1918 Wisła Kraków season

The script doesn't detect the bundled articles in this nom (just tested in sandbox) czar 19:04, 5 December 2019 (UTC)

The additional articles were using a different list type – this edit makes it work - Evad37 [talk] 02:46, 6 December 2019 (UTC)

Would it be worth adapting the bullets (as an alternative to the indents/colons)? Imagine this won't be the last time this happens czar 04:01, 6 December 2019 (UTC)

Closing templates

Add a "mark as closing" button?

 New proposal

It would be nice if the "[Close][quickClose][Relist]" line included as "mark as being closed" button, which would add a {{closing}} template. Sure, you can add the template yourself, but it's enough of an annoyance that I often don't bother, and then get edit conflicted. If it was a one-clicker, I'd be more likely to use it often. -- RoySmith (talk) 15:53, 22 April 2019 (UTC)

 Acknowledged as a good idea - Evad37 [talk] 23:14, 16 December 2019 (UTC)

How to handle "closing" templates

Is it possible to have XFDCloser remove a {{closing}} template when closing a discussion? I've noticed on Wikipedia:Articles for deletion/I'm a Celebrity...Get Me Out of Here! (British series 1) that it leaves these templates in. Jo-Jo Eumerus (talk) 09:47, 3 December 2019 (UTC)

@Jo-Jo Eumerus: Yes, it should already do so, but the template needs to be placed under the section heading rather than the top of the page (and the same for {{AfDh}} and {{AfDb}}). - Evad37 [talk] 02:56, 4 December 2019 (UTC)

Having a button for the script to add the template with a click, per the above, would probably solve this because then the closer wouldn't have to remember to place it under the section heading - Evad37 [talk] 23:07, 16 December 2019 (UTC)

Update to {{Old XfD multi}}

I've recently had some changes made to {{Old XfD multi}} that allow non-AfD discussions to use the page parameters of the template rather than link. This works by not adding the "Wikipedia:Articles for deletion/" prefix to pages with a namespace prefix. The old method for linking to discussions will continue to work, so no update is needed to handle valid nominations (although non-article AfDs using the page parameter may cause issues). However, updating to use this feature will lead to cleaner wikitext, so it's up to you if you want do this. Danski454 (talk) 18:44, 23 August 2019 (UTC)

 Acknowledged. Should be done for cleaner wikitext, but its a low priority given the existing method still works. (Patches welcome, if anyone technical wants to work on this.) - Evad37 [talk] 23:24, 16 December 2019 (UTC)

Wikipedia:Requested moves?

This has probably been brought up before, but just curious: Any chance this script can be configured to also handle closing WP:RM requests? Steel1943 (talk) 16:21, 20 December 2019 (UTC)

Possibly, it does seem similar enough (close a discussion within a section of a page, then have some edits/actions to another page). I will have to do some further investigation, including how to quickly determine if a talk page has an open RM discussion (I don't want to needlessly load the full script on every talk page). - Evad37 [talk] 02:09, 23 December 2019 (UTC)

There's a cat for that Category:Requested moves ‑‑Trialpears (talk) 02:13, 23 December 2019 (UTC)

I believe @Danski454: has as separate script in the works for this. See User:Danski454/RMcloser.js. Looking at the code suggests that it would be capable of doing a lot of fancy things just like XFDcloser. SD0001 (talk) 06:39, 23 December 2019 (UTC)

That script is pretty unfinished, but works for relisting RMs. Danski454 (talk) 12:23, 23 December 2019 (UTC)

Bug? - not deleting "Talk:IQ classification/Archive 1"

Hi. A while ago I closed a discussion as delete but it looks like the script failed to delete (and I failed to notice it, but someone pointed it to me and deleted the page afterwards). Links: the MfD page, and the page itself: Talk:IQ classification/Archive 1 (which exists, again, because it was recreated as a move from some other page). Maybe the script does not like to delete "Talk:.*", or "Talk:.*/.*", pages? Thanks! - Nabla (talk) 15:59, 17 February 2020 (UTC)

Suggestion - add retarget link to OldRfd?

Hi. A (very low priority) suggestion. Is it possible to add a link to the retargeted to page when closing a RfD as retarget? I like to add it, because I think it is important information about the closure, I do not know if it is common enough, and wanted enough, to be worth the effort; but as it probably is not a huge effort, you already have all the info, it is probably "only" adding it to one string. See a example diff. - Nabla (talk) 16:05, 17 February 2020 (UTC)

DRV

Noting there's a suggestion at [3] that XFDcloser should handle closing of WP:Deletion review discussions, including adding {{olddelrev}} to talk pages as appropriate - Evad37 [talk] 00:45, 26 February 2020 (UTC)

Suggestion: logging of deletion actions

It would be useful if all the automated actions associated with closing an AfD as delete could be logged, probably to the article's talk page (and creating one if necessary). That way, if the deleted article is ever restored, you'd have a record of what incoming links had been removed, making it easier to restore them. It's probably not possible to fully automate the restoration process (even if the log was machine parsable), but at least having a human-readable log would be useful.

Hmmm, as I'm writing this, it occurs to me that the information actually already exists. It should be possible to datamine the deleting user's contribution log to discover this. I need to think on that. -- RoySmith (talk) 15:39, 26 February 2020 (UTC)

Deleting redirects that are at RFD

When deleting redirects to other deleted pages, XFDcloser incorrectly handles redirects that are currently at RFD. Rather than deleting those as well, it simply removes the link so that the pages look like this: "[Template:rfd, which for technical reasons shouldn't be transcluded]
#redirect Foo" This is obviously not desirable, so can it be fixed? (I don't know precisely how XFDC works, so excuse any errors in that department.) Glades12 (talk) 10:57, 25 February 2020 (UTC)

Okay, so there's two things happening here, because an RFD'd redirect isn't seen by the MediaWiki software as a redirect:

1. The RFD'd redirect isn't deleted when other redirects are deleted.
2. When it comes to unlinking backlinks, the RFD'd redirect is treated just like an article, so the #REDIRECT [[Article]] line within the RFD template is changed to #REDIRECT Article

Deleting a redirect that is already being discussed at RFD is necessarily the best outcome in all cases – e.g. if the RFD discussion is heading towards a retarget outcome. Though I suppose it could be recreated pointing to a new target. Another possible "fix" is to have XFDcloser ignore RFD'd redirects, and leave them to be dealt with by whoever closes the RFD discussion. I'll leave a note at WT:RFD so we can get some more thoughts on this. - Evad37 [talk] 00:39, 26 February 2020 (UTC)

• Redirects being discussed at RfD should definitely not be deleted after the deletion of the target. Retargeting or disambiguating are pretty common outcomes, and in those cases what's become of the original target is irrelevant. – Uanfala (talk) 00:59, 26 February 2020 (UTC)

• I can respect that opinion, but simply removing the link should not be done either way. It is likely to confuse readers ("'Click on the link below'? I don't see any!") and creates an extra step for a "keep" outcome. Glades12 (talk) 19:04, 26 February 2020 (UTC)

Withdrawal?

Could the procedure for non-administrator close (nominator withdrawal) be added as an option?--Goldsztajn (talk) 12:13, 12 March 2020 (UTC)

Isn't that just a Speedy keep close with a rationale of Nomination withdrawn? - Evad37 [talk] 01:25, 13 March 2020 (UTC)

As far as I can tell, yes, that's the case. I was just asking whether it could be made an explicit option - I've seen a case of an editor closing incorrectly using this tool (ie closing when a withdrawal should have been undertaken) and I think for new editors having this option more explicitly visible could be helpful. At the same time, I do not know the ins and outs of the coding for this, so the cost-benefit ratio might not be worth it. Regards, --Goldsztajn (talk) 11:20, 13 March 2020 (UTC)

I don't see this as necessary - the "custom" option works just as well (and actually means the talk page notices will say "withdrawn"). Primefac (talk) 13:58, 15 March 2020 (UTC)

Bug Report - FfD delete link is not updated on re-list

the link I'm referring to, for reference

I've noticed that when re-listing files at FfD (example), the "delete" link is not updated to the current listing's date. Could this please be fixed? Thanks, FASTILY 03:35, 22 April 2020 (UTC)

Friendly ping for @Evad37 :) -FASTILY 03:52, 30 April 2020 (UTC)

@Fastily: This is something I should be able to fix in the next major version of XFDcloser. Any manual relists done follow the current WP:FFDAI instructions will also have the same issue... I'm not sure how often relists are done manually, but fixing such links would be suitable for a bot task. - Evad37 [talk] 08:26, 30 April 2020 (UTC)

Awesome, thanks! :D -FASTILY 05:16, 1 May 2020 (UTC)

Unlinker removes citation

Looks like this example came up in the unlinker/delinker. If possible, would be nice to add these cases to be excluded from the logic that asks whether the line should be removed. czar 11:56, 26 May 2020 (UTC)

If I remember correctly, when there is a list item like this it asks if you want to delink or remove the list item entirely. I don't know if it was just a misclick or overlooked option (Spartaz would be the one to ask about that) but that would be my guess as to the reason. Primefac (talk) 20:36, 26 May 2020 (UTC)

It was a miss click. At that point you will see I immediately rolled myself back when I saw what I had done. Is it possible to exclude links popping up that have tye text cite in them or are more than a certain size? Spartaz ^Humbug! 21:45, 26 May 2020 (UTC)

Usage on other wikis

I would like to know how this gadget can be used in other Wikis. Will it only require importing MediaWiki:Gadget-XFDcloser.js to the target wiki? Adithyak1997 (talk) 10:33, 1 June 2020 (UTC)

@Adithyak1997: There are four files required:

• MediaWiki:Gadget-XFDcloser.js
• MediaWiki:Gadget-XFDcloser-core.js
• MediaWiki:Gadget-XFDcloser.css
• MediaWiki:Gadget-libExtraUtil.js

Each of the three js files require a line in MediaWiki:Gadgets-definition, here on enwiki they are in the "maintenance" section. XFDcloser also depends on MediaWiki:Gadget-morebits.js and MediaWiki:Gadget-morebits.css; if your wiki has Twinkle available then these should already be there.
Next you will need to translate and localise parts of Gadget-XFDcloser.js (which controls which pages load the core gadget) and Gadget-XFDcloser-core.js (which contains the main code). This depends on how your deletion process(es) are set up, but you can get some hints from urwiki, which made their localised copies last December: ur:میڈیاویکی:Gadget-XFDcloser.js and ur:میڈیاویکی:Gadget-XFDcloser-core.js (see also Wikipedia talk:XFDcloser/Archive 4#XFDcloser on Urdu WIki). - Evad37 [talk] 01:31, 2 June 2020 (UTC)

Do not merge

User:Evad37, It would be great to have a "do not merge" option for merge discussions. Right now, I use "custom" with "do not merge" as the result and then I subsequently edit the talk pages to add the |merge= or |mergeX= parameter to the XFD result template. For example, here and here. Thanks for script/gadget, its been big timesaver. Plastikspork _―Œ^(talk) 14:11, 4 June 2020 (UTC)

I concur; it always feels weird listing "keep" for a template merge discussion. If it makes it any easier, I think TfD is the only venue where this would be a useful close rationale. Primefac (talk) 16:52, 4 June 2020 (UTC)

Adding old XfD templates before deletion

If I'm not mistaken, XFDcloser only adds {{Old AfD multi}} etc. if the page is kept. But the template is also useful (perhaps more useful) for recording when a page is deleted at XfD and subsequently recreated. Would it be possible to get the gadget to add the old XfD templates to the talk page immediately before it is deleted? – Joe (talk) 12:14, 12 June 2020 (UTC)

I seem to recall that AnomieBOT goes around and adds {{Old AfD multi}} to the talk pages of recreated deleted-at-AFD articles. Primefac (talk) 17:18, 15 June 2020 (UTC)

Unlinking "cancelled by user"

I closed AfDs for the first time in a while today, and the script keeps skipping the "unlinking backlinks" step, saying that I've cancelled it, when I haven't. Is this a bandwidth issue? Because it doesn't happen every time...or is it something else? Vanamonde (Talk) 16:25, 20 July 2020 (UTC)

XFDcloser doesn't recognize RfD tag placed by page curation tool

Tracked in github.com
Issue #65

I recently closed the RfD associated with the redirect Software Entertainment Company using XFDcloser. However, when I did so, it did not recognize the RfD template in this revision. Because of that, XFDcloser claimed there was no RfD template on the redirect, and did not remove the template from the redirect. (Of course, I ended up removing the template manually.) I'm assuming the issue is related to the template the Page Curation tool uses to tag pages for RfD, which seems to be {{Rfd-NPF}}. Steel1943 (talk) 00:23, 30 August 2020 (UTC)

The same issue happened with this revision's template on Nanay Baby. Steel1943 (talk) 01:45, 30 August 2020 (UTC)

 Acknowledged. Wow, I had no idea that template even existed. Makes things a tad more complicated. - Evad37 [talk] 00:54, 31 August 2020 (UTC)

Too strict enforcement of BADNAC

Consider this scenario:

1. Alice nominates a page for deletion
2. Bob thinks it's so clear-cut that a deletion discussion isn't needed, and so tags the page for speedy deletion
3. Carol, an admin, agrees with the speedy deletion tag and deletes the page, but doesn't do anything with the deletion discussion
4. Dave, not an admin, tries to use XFDcloser to close the deletion discussion with the result "Speedy delete (by Carol)".

XFDcloser will disallow this close, saying "Non-admin closure is not appropriate when the result will require action by an administrator (per WP:BADNAC)". We should adjust it to allow non-admins to choose the "delete" reason if the page in question is already deleted. Jackmcbarn (talk) 21:50, 10 August 2020 (UTC)

In that situation, it'd be best to use the custom feature so you can say "speedy deleted" in the past tense to show that it's already been deleted, and the additional rationale to say who deleted it and with which criterion. -- Tavix ^(talk) 21:56, 10 August 2020 (UTC)

Tavix, I agree that custom makes sense here. I'd probably write, "Moot, has already been speedy deleted", but yeah, that's what custom is there for. -- RoySmith (talk) 22:08, 10 August 2020 (UTC)

• Using "custom" is what I do, and then I put "speedy delete" as my reason. Steel1943 (talk) 22:34, 10 August 2020 (UTC)
• For what it's worth (regarding John's Jack's last point) I don't think the script checks for the page existing until after the close option is selected, so potentially allowing a NAC/delete immediately followed by "oh sorry, it exists so you can't do that" is problematic. Agree with the above suggestions regarding custom closes (which I do on occasion even as an admin). Primefac (talk) 22:56, 10 August 2020 (UTC)

  ...Primefac, who is "John"? Steel1943 (talk) 22:58, 10 August 2020 (UTC)

  John... Jack... all the same, right? Primefac (talk) 23:00, 10 August 2020 (UTC)

  ...Yeah, yeah... Steel1943 (talk) 23:45, 10 August 2020 (UTC)

This issue has been raised before. Perhaps the non-admin view should have a little note saying to use the custom close option if a page has already been deleted. - Evad37 [talk] 01:02, 31 August 2020 (UTC)

Weird close for Modules

So I just closed this discussion as a merge to Module:ISO 639 name, but the script put {{being deleted}} on that module's /doc. I know the module handling is already a little odd, but it should (in theory) work the same as template mergers, and just remove the TFD tags from the merge target. Primefac (talk) 01:22, 6 August 2020 (UTC)

@Primefac: I think that is the same as templates (except for being onlyincluded on the doc instead of noincluded on the page itself) - {{being deleted}} can be used for merges. Or have I missed something? - Evad37 [talk] 01:10, 31 August 2020 (UTC)

Well, for example, when I closed this discussion as "merge to Template:Lymphatic organ and vessel disease" (using the radio button and with no other settings changes), the "to be merged" template got a being deleted template while the target template had the tfm template removed. I suspect that in the example I gave above, since the "merge to" target wasn't the /doc, it changed the tfm to {{being deleted}} as if it were being merged to the target. Primefac (talk) 01:25, 31 August 2020 (UTC)

Proposal - limiting use of WP:XFDCloser to those on a list, similar to WP:AFC tool user list

Notice: Discussion is taking place at Wikipedia talk:Non-admin closure#Proposal - limiting use of WP:XFDCloser to those on a list, similar to WP:AFC tool user list (permalink). davidwr/(talk)/(contribs) 17:27, 23 September 2020 (UTC)

Speedy deletion reason

If you close an XfD as "speedy delete", the page's deletion reason will just be a link to the XfD discussion, as if it were just closed as "delete". I think it would make more sense for the deletion reason to contain the given reason in that case, though. Jackmcbarn (talk) 16:50, 3 October 2020 (UTC)

I can potentially see the benefits of this; there have been a couple of times recently where I've deleted something as G12 or because it required suppression, and I deleted it first and then closed the AFD so that it was clear that it wasn't an "AFD deletion" that could be subject to G4. Not sure how easy it would be to implement, or what the final message should be, since I can see things like SNOW deletions being technically "speedy" but not necessarily requiring any extra info on the deletion log. Primefac (talk) 16:54, 3 October 2020 (UTC)

TfD merge to holding cell

When selecting the merge option, XFDcloser would currently add the following to WP:TFDH:

• Template:Userpage_otheruse2020 September 18 – Userpage_otheruse ( links | transclusions | talk | doc | sandbox | testcases )
• Template:User_page2020 September 18 – User_page ( links | transclusions | talk | doc | sandbox | testcases )

What do we think about organising this slightly differently? Along the lines of:

• To {{User_page}}:
  • Template:Userpage_otheruse2020 September 18 – Userpage_otheruse ( links | transclusions | talk | doc | sandbox | testcases )

When closing, the closer is required to select a single merge target (which would be line one). All other templates would be sub-bullets. Would help TFDH look less like this. Technically, it would be done in Task.prototype.doTask.addToHoldingCell I think. ProcrastinatingReader (talk) 17:34, 26 September 2020 (UTC)

It would certainly minimize the amount of followup needed to indicate which template is being merged into which, or at the very least indicate which pairs of templates belong to the same discussion. Primefac (talk) 00:56, 6 October 2020 (UTC)

Another thought, which might be easier, would be to set the merge target as "keep" and not even list it at TFDH. Primefac (talk) 01:00, 16 October 2020 (UTC)

I think it's useful to have the target of the merge listed. I know it's only a click away from the discussion and seeing it there, but when you have more than 1 template being merged into the same target, it's more clear listing them all under a shared target. --Gonnym (talk) 17:09, 16 October 2020 (UTC)

Fair point. Primefac (talk) 17:21, 16 October 2020 (UTC)

Relisting phrase bug

Clicking relist button, cancelling, then taking a quick delete action shows "reload page to see the actual relist" rather than "reload page to see the actual close" I'm guessing it's maybe because the relisting var isn't unset after closing the dialog, but haven't looked closely enough. Minor thing, don't think it's taking any relist actions after the close, but just pointing it out. ProcrastinatingReader (talk) 00:29, 20 October 2020 (UTC)

Quick-delete functionality at TfD listing in "to orphan"

Preceding discussion: User_talk:Pppery#Noinclude_list_and_XFDCloser

Closing a TfD as "quick-delete" causes the template to be listed at "to orphan" in TfD Holding, rather than tagging it for deletion. I figured it may be because User:Pppery/noinclude list transcludes every template which would fit that category, but not sure. If that is indeed the case, is there any way this template can exclude "User:Pppery/noinclude list" for the "has transclusions" check (I assume one is taking place when deciding where in holding to put the page, but I haven't looked at the source)? ProcrastinatingReader (talk) 17:58, 23 October 2020 (UTC)

As far as I'm aware, tagging something for deletion is not dependent on whether there are existing transclusions. I say this because I have had (on multiple occasions in the past) found that a template tagged for G6 post-TFD still has them. Primefac (talk) 18:07, 23 October 2020 (UTC)

There's never been a transclusions check for quickDelete. The listing at the holding cell is intentional, a human ought to be making the decision that a template is really ready for deletion before the speedy deletion tag is applied. A delete result does not necessarily mean the template is ready to be tagged. - Evad37 [talk] 02:29, 24 October 2020 (UTC)

Collateral deletions?

There's something odd in this deletion log (the entry from earlier today) – judging from the edit summary, this was part of the closure of one MfD discussion, but the result was the deletion of another, unrelated, page (whose MfD had concluded as "keep" several hours previously). What has happened here?

An unrelated incident from a few days ago (which involved the same admin) had resulted in the G8 deletion of Talk:Islamic languages, a page that I seem to recall having tagged with {{G8-exempt}}. Was this an automatic action that wasn't supposed to happen, or could it have been a deliberate action by the admin? – Uanfala (talk) 21:01, 31 October 2020 (UTC)

This duplicates the thread immediately below. – Uanfala (talk) 01:08, 1 November 2020 (UTC)

As you noted, the unrelated deletions is Wikipedia talk:XFDcloser/Archive 4 § Potential bug below. The G8-exempt deletion would have been an automated action (or semi-automated, as the script allows users to specify not to delete talk pages, but the default option is for deletion). Will look in to modifying the script so that it checks for G8-exempt before deleting. - Evad37 [talk] 01:13, 1 November 2020 (UTC)

Bug: TfD detects any Template:Lt as being nominated

In Wikipedia:Templates for discussion/Log/2020 November 7#Template:Ethiopian-Eritrean Cultural and Historical Community, presumably since Gyrofrog used Template:Lt when discussing a template in a comment, XFDCloser (when closing) thought that template was part of the TfD and hence tried to take automated actions on it (Special:Diff/988714563). Perhaps it should only try to detect Template:Tfd links (and that too, at the start of the nomination)? ProcrastinatingReader (talk) 22:22, 14 November 2020 (UTC)

I wondered what had happened there -- I would not be sorry to see Template:Habesha peoples go, seeing how I previously nominated it. But it was not up for discussion, except to compare its past editing patterns with the template that was under discussion. -- Gyrofrog (talk) 23:18, 14 November 2020 (UTC)

XFDcloser works with the generated HTML rather than the wikitext. In that respect, it is very hard to tell the difference between tfdlinks and lt. Only detecting initial pages would miss out on nominated pages within collapse templates, or added below the nomination statement. - Evad37 [talk] 04:19, 18 November 2020 (UTC)

Further goes to show the "operator takes responsibility" aspect of some of these scripts/tools. I try to always give a quick check to the top of the edit box to see if the number of templates being changed is the same number that were nominated. Primefac (talk) 14:56, 18 November 2020 (UTC)

Beta: Unlinker shows incomplete number as done

"Unlinking backlinks: Done! (3/4)" is counterintuitive (4/4 is "done"). I've never been dissatisfied with anything the closer has skipped. I think it's fine to mark this as "4/4"/fully processed. It's fine to have a collapsed/unfurlable "show skipped" but otherwise hide the hazard/warning triangle symbol and save that only for something that warrants action. Having the status is nice when I want to click through, but all I really need to know after the close is whether it was successful or needs manual intervention. czar 21:56, 25 December 2020 (UTC)

Don't update the old log page if updating the new log page fails

See the edit in the middle here with the edit summary "Relisting Wikipedia:Articles for deletion/Cathy Tie (2nd nomination)". For some reason, neither updateDiscussion nor updateNewLogPage ran successfully, but updateOldLogPage did, so the discussion wasn't transcluded anywhere until Cyberbot noticed it a couple of weeks later.

Probably extremely uncommon for this to happen, but possibly updateOldLogPage could be deferred until the others have finished successfully?

– Thjarkur (talk) 22:09, 22 January 2021 (UTC)

I can look at doing something like this for version 4, but ultimately as Primefac says above there's a certain amount of "operator takes responsibility", especially since XFDcloser does show the status of tasks it undertakes, and reports errors it encounters. – Evad37 [talk] 23:55, 22 January 2021 (UTC)

Beta bug: Can't close as "Delete" at TfD

Also no "soft delete" option (works in v3, not v4-beta). ProcrastinatingReader (talk) 13:29, 23 January 2021 (UTC)

@ProcrastinatingReader: Should be fixed now - Evad37 [talk] 17:45, 23 January 2021 (UTC)

One more small thing: Ticking soft inserts the rationale into the box, but unticking it doesn't remove it. I wonder if the rationale should actually be shown in the prefill, or just added automatically / not customisable (the same way how you can't customise the "delete" text in the message when selecting the "Delete" option).

One more: Dragging the box around sometimes causes text to be selected (cursor turns into a selector). Seems to happen more often when you drag it quickly rather than very slowly. Doesn't happen with the v3 when moving the v3 box around.

A bit tedious, I know, but stood out to me :P

Thanks for all your work on v4 by the way! Much appreciated. ProcrastinatingReader (talk) 17:53, 23 January 2021 (UTC)

Advance notice: Version 4 deployment

I planning to deploy version 4 of XFDcloser next week, probably MondaySunday. It has been available as a beta version since last November. While there are some minor issues still to be worked on, I don't think they are significant enough to delay rolling out the new version. As well as a new user interface, the introduction of some preferences, and making the "unlink backlinks" functionality available for any non-existent page, version 4 fixes various issues reported above, including

• Wikipedia talk:XFDcloser/Archive 5 § Watchlist
• Wikipedia talk:XFDcloser/Archive 5 § Rename option for CfD
• Wikipedia talk:XFDcloser/Archive 5 § Log summary change request
• Wikipedia talk:XFDcloser/Archive 5 § Automated actions at CfD
• § A little bug: "{{subst:^|<strong>}}" showing up inside references

Thank you to the editors who have been testing out the beta version. At this stage I intend to keep the beta version around for trialling any new features and other non-urgent updates prior to the main version. - Evad37 [talk] 03:47, 26 January 2021 (UTC) Updated 10:54, 30 January 2021 (UTC)

 Done - Evad37 [talk] 01:15, 31 January 2021 (UTC)

Bug: Previous discussion links malformatted in talk page template

It looks like when updating talk page links, the script currently tries to access logs at Wikipedia:Redirects for discussion/Log/DD Month YYYY instead of Wikipedia:Redirects for discussion/Log/YYYY Month DD. Examples from my recent closures are Talk:Complete list of species in genus Persea, Talk:Complete list of Grewia species, Talk:Red Indians, Talk:Red Indians. _signed, Rosguill ^talk 17:53, 31 January 2021 (UTC)

Just noting that I've manually corrected the above pages, but as far as I know the underlying issue remains unaddressed. _signed, Rosguill ^talk 20:10, 31 January 2021 (UTC)

@Rosguill:  Fixed. Needing a ymd date there is just one more of those slight differences between the various xfd processes that I happened to miss. - Evad37 [talk] 00:59, 3 February 2021 (UTC)

Beta: Unlinking failed

Closed Wikipedia:Articles for deletion/Stirrings Still (journal) as quick delete and received a notice that the unlinking failed (so I did it manually) czar 10:01, 30 January 2021 (UTC)

I just tried it out on the testwiki, and it worked fine there [4], so I'm not sure what's going on... - Evad37 [talk] 10:40, 30 January 2021 (UTC)

Extended content

load.php?lang=en&modules=jquery|jquery.ui&skin=monobook&version=1bti2:144 JQMIGRATE: Migrate is installed with logging active, version 3.1.0 load.php?lang=en&modules=jquery|jquery.ui&skin=monobook&version=1bti2:155 This page is using the deprecated ResourceLoader module "jquery.ui". Please use OOUI instead. mw.loader.implement.css @ load.php?lang=en&modules=jquery|jquery.ui&skin=monobook&version=1bti2:155 load.php?lang=en&modules=jquery|jquery.ui&skin=monobook&version=1bti2:144 JQMIGRATE: jQuery.fn.delegate() is deprecated migrateWarn @ load.php?lang=en&modules=jquery|jquery.ui&skin=monobook&version=1bti2:144 /w/index.php?title=User:Theopolisme/Scripts/adminhighlighter.js&action=raw&ctype=text/javascript:41 Admin highlighter recoverable error Bad constructor arguments (anonymous) @ /w/index.php?title=User:Theopolisme/Scripts/adminhighlighter.js&action=raw&ctype=text/javascript:41 VM95:23 This page is using the deprecated ResourceLoader module "mediawiki.ui". Please use OOUI instead. mw.loader.implement.css @ VM95:23 load.php?lang=en&modules=jquery|jquery.ui&skin=monobook&version=1bti2:51 jQuery.Deferred exception: Cannot read property 'match' of undefined TypeError: Cannot read property 'match' of undefined     at exports.default (http://en.wiki.x.io/w/load.php?lang=en&modules=ext.gadget.XFDcloser-core-beta&skin=monobook&version=13fe1:541:364)     at UnlinkBacklinks.value (http://en.wiki.x.io/w/load.php?lang=en&modules=ext.gadget.XFDcloser-core-beta&skin=monobook&version=13fe1:314:851)     at http://en.wiki.x.io/w/load.php?lang=en&modules=ext.gadget.XFDcloser-core-beta&skin=monobook&version=13fe1:314:328     at processPage (http://en.wiki.x.io/w/load.php?lang=en&modules=ext.gadget.XFDcloser-core-beta&skin=monobook&version=13fe1:510:586)     at http://en.wiki.x.io/w/load.php?lang=en&modules=ext.gadget.XFDcloser-core-beta&skin=monobook&version=13fe1:511:663     at Array.map (<anonymous>)     at http://en.wiki.x.io/w/load.php?lang=en&modules=ext.gadget.XFDcloser-core-beta&skin=monobook&version=13fe1:511:637     at mightThrow (http://en.wiki.x.io/w/load.php?lang=en&modules=jquery%7Cjquery.ui&skin=monobook&version=1bti2:49:149)     at process (http://en.wiki.x.io/w/load.php?lang=en&modules=jquery%7Cjquery.ui&skin=monobook&version=1bti2:49:808) undefined jQuery.Deferred.exceptionHook @ load.php?lang=en&modules=jquery|jquery.ui&skin=monobook&version=1bti2:51

I think this was my log, if it helps czar 01:43, 31 January 2021 (UTC)

That helps narrow down where the error is occurring... though I still have no idea as to the why... - Evad37 [talk] 01:16, 3 February 2021 (UTC)

Bug - target template has new procedure?

So I just closed this discussion, which resulted in a merge to {{Infobox officeholder}}. However, that template was subsequently tagged with {{being deleted}}, despite the fact that it, well, isn't being deleted. Pre-version-4 versions of this tool would just remove the {{tfm/dated}} template for any merge target. Is this new procedure intentional or a bug? Primefac (talk) 13:50, 8 February 2021 (UTC)

CfD feedback

It's great that CfD has some support for automated actions, I've started closing CfDs again partly because of it. I just have some feedback on how to make it even better without a huge time investment. I think the option to remove nomination templates and tag talk pages should be available for renames, merges and redirects to, now I've closed them using custom to actually get the option. Also worth noting that closing CfDs as redirect is very rare since category redirects don't work properly. By my count only 7 of the over 5000 CfDs in 2020 were closed as redirect. I would probably replace it with upmerge which is a lot more common. --Trialpears (talk) 21:37, 11 February 2021 (UTC)

"Next" feature

Not a fan of having to click through two panes to close as opposed to one, especially since the second pane seemingly has so few options; could this not simply be included in the first pane for expedience and convenience? That aside, the option to make the close result part of a new sentence or not was sorely needed and is much appreciated. — Godsy ^(TALK_CONT) 15:09, 12 February 2021 (UTC)

As much as I hate to say it (because I know how much work goes into such things) I did much prefer the old interface as it was a "one stop shop" for a close. Not sure what Godsy is referring to with regard to the "new sentence" option, as that was available on ver.3. In other words, 1 click > 2 clicks.

That being said, from the TFDs I've closed so far I feel like the new interface is more dynamic (with regard to the close itself) which I appreciate. I suppose you can't have one (more reactive) without the other (more clicks). Primefac (talk) 03:04, 13 February 2021 (UTC)

RfD bug?

This edit by Rosguill is not how XFDcloser ought to behave. Is that because of this change by JJMC89, i. e. because the module was renamed? 𝟙𝟤𝟯𝟺𝐪𝑤𝒆𝓇𝟷𝟮𝟥𝟜𝓺𝔴𝕖𝖗𝟰 (𝗍𝗮𝘭𝙠) 13:24, 19 February 2021 (UTC)

• Additional examples by myself: Special:Diff/1007698389, Special:Diff/1007706854. XFDCloser also fails to update the redirect page when retargeting. 𝟙𝟤𝟯𝟺𝐪𝑤𝒆𝓇𝟷𝟮𝟥𝟜𝓺𝔴𝕖𝖗𝟰 (𝗍𝗮𝘭𝙠) 14:35, 19 February 2021 (UTC)
• Using search, I found only two additional cases where the issue was overlooked: Special:Diff/1007400092 (@Tavix:) and Special:Diff/1006625450. Interestingly, retargeting worked both where "Redirect for discussion" was used and where I reverted the page to the revision where "RfD" was used. 𝟙𝟤𝟯𝟺𝐪𝑤𝒆𝓇𝟷𝟮𝟥𝟜𝓺𝔴𝕖𝖗𝟰 (𝗍𝗮𝘭𝙠) 14:51, 19 February 2021 (UTC)

These issues with RfD closing remain unresolved and are quite annoying. _signed, Rosguill ^talk 21:38, 22 February 2021 (UTC)

I've reverted the edit that seems to have caused these issues [5]. No changes to XFDcloser should be necessary now. However, the issue will still persist for the redirects currently nominated. – Uanfala (talk) 00:14, 1 March 2021 (UTC)

I've attempted to fix the 272 redirects currently tagged for RfD. XFDcloser should hopefully work now, but it's worth keeping an eye out just in case. Pings to editors I recall seeing closing discussions recently: Rosguill, Tavix, Thryduulf, BDD, Hog Farm, CycloneYoris, Mazca. – Uanfala (talk) 01:07, 1 March 2021 (UTC)

Thanks @Uanfala, that was a lot of work that wouldn't have been necessary if people tested things before making changes they assumed would not break anything. I don't use XFDcloser (or most other automation for that matter, just the closure links) but thanks for the ping. Thryduulf (talk) 02:35, 1 March 2021 (UTC)

Thanks for informing me. I need to get around and learn the manual process for closing XFDs for when things like this happen. Sounds like some form of a smoke test should have happened before the changes. Hog Farm _Talk 04:26, 1 March 2021 (UTC)

Hog Farm, there are a few legacy scripts still kicking about that will at least close the discussion for you, for example I still use User:DeirdreAnne/closetfd.js for closing TFDs when there are weird formatting issues that XFDC can't deal with. I don't remember the "low-tech" script for AFDs, but I do know they're out there (maybe this?). Primefac (talk) 13:01, 1 March 2021 (UTC)

Thanks for thinking of me... I still close by hand. :) --BDD (talk) 15:51, 1 March 2021 (UTC)

Super duper corner case weirdness

So! I just closed Wikipedia:Articles for deletion/Lloyd Yancey, an article about a man who didn't do enough sports to become notable. Super. Imagine my surprise when he had several dozen links to his name. Now imagine my surprise when a bunch of them turned out to be links to Chestnut Hill Academy. That's weird, because that article isn't a redirect to Lloyd Yancey. It does feature, interestingly, a redirect to Springside Chestnut Hill Academy, except somebody didn't actually remove the content from the Chestnut Hill Academy article when they added the redirect link to Springside. And, surprise surprise, Chestnut Hill Academy contained a link to Lloyd Yancey!

So it turns out that in the unlikely event that the article being deleted is wikilinked in an article that contains redirect markup as well as article content, the unlink function of XfDcloser will treat that second article as a redirect target to the article being deleted, even if the redirect link points elsewhere. Damned unlikely, but one never knows. I'll clean up the mess myself; this is mostly to inform anyone else who has this issue in the future. ♠PMC♠ (talk) 22:40, 2 March 2021 (UTC)

I created a test case for this over on the Test Wikipedia; XFDCloser seems to use the backlinks API ([6][7]); the backlinks API gives different results from Special:WhatLinksHere in that case (but they match for the redirect target). Seems like a bug in the backlinks API to me. --Pokechu22 (talk) 00:32, 3 March 2021 (UTC)

I feel like there should be a check or category that lists pages starting with #REDIRECT that contain more than a certain amount of text, which would indicate that it doesn't just contain {{rcat shell}} but might be hiding an "article"... Primefac (talk) 14:19, 3 March 2021 (UTC)

I've created phab:T276408 for the backlinks API issue. A category for large redirects (or better, redirects that contain content not enclosed in {{rcat shell}} or something using {{Redirect template}}) would be useful, but I don't know entirely what it'd look like or where that'd be implemented. --Pokechu22 (talk) 02:47, 4 March 2021 (UTC)

A quarry would probably work (poke). Primefac (talk) 13:16, 4 March 2021 (UTC)

Primefac, https://quarry.wmflabs.org/query/52967 --AntiCompositeNumber (talk) 19:27, 4 March 2021 (UTC)

Cheers, ta. Primefac (talk) 19:39, 4 March 2021 (UTC)

You almost shocked me into thinking you could query page contents from the database with Quarry until I saw the query. 𝟙𝟤𝟯𝟺𝐪𝑤𝒆𝓇𝟷𝟮𝟥𝟜𝓺𝔴𝕖𝖗𝟰 (𝗍𝗮𝘭𝙠) 16:11, 5 March 2021 (UTC)

withdrawal

trying to do a speedy withdrawal, but the 'next' button is greyed out. what do? --Ysangkok (talk) 16:55, 10 March 2021 (UTC)

Did you make sure you had all of the appropriate boxes checked? The new XFDC doesn't give you the "next" button until everything has been filled in. Primefac (talk) 17:54, 10 March 2021 (UTC)

Bug: "undefined" unlink reason

While unlinking Sunday Driver (film), which was PROD-deleted in December, XFDcloser put "undefined" (including the link) as the unlink reason (cf. [8][9][10]). In the popup, the reason was automatically set to the page's delete reason and not altered. The page was open in Visual Editor mode (i.e. [11]), which could be the cause of this bug, although it would be an odd one. IceWelder [✉] 11:13, 18 March 2021 (UTC)

Bug (?) - TfD closures not removing templates

In the last few days I've seen a large number of templates that were closed as "delete" and listed at the Holding Cell (pretty much everything from 13 Mar and 14 March) where the {{Template for discussion/dated}} template was not removed. I wasn't aware of any major/recent changes to XFDC, so... any idea what happened? Did this set of changes or this change mess up the language the script was looking for? Primefac (talk) 18:02, 21 March 2021 (UTC)

I think it might have been the addition of |otherpages=, as this close didn't have that parameter and it worked as normal. SMcCandlish, what was the intention behind Special:Diff/1010900409, as I don't quite follow the logic or see the need (especially since Twinkle doesn't add this param anyway?). Primefac (talk) 18:10, 21 March 2021 (UTC)

Why would addition of a parameter that isn't much used have any general effect? It shouldn't trigger any response from a bot except in cases where someone uses the new parameter. As for the purpose of the parameter, it is covered in the /doc – it's for cases when TfD rather than RM is used for a template move/rename, e.g. because the move needs to happen as part of broader template cleanup action and isn't just an "I think this would be better named as ..." proposal, or when the input needed is probably going to come entirely from TfD regulars, like when the page in question is a meta-template that other templates depend on and which editors don't interact with directly.  — SMcCandlish ☏ ¢ 😼  20:05, 21 March 2021 (UTC)

Thanks for the explanation of the param. As far as cleanup goes, if the script is looking for the exact formatting of the template use before you added the extra param, then it will be unable to parse its removal now that it's been added. This seems to be the only change that I can see that would cause the script to stop working. I'm not saying we have to remove the parameter from the template, and with pppery's change to make it optional we might see fewer of these instances, but it would still be good to have the script be a little more robust. Primefac (talk) 12:50, 22 March 2021 (UTC)

RfD Rcat R from less specific name has an extra closing curly bracket

I noticed that both in the selection menu (for selecting which Rcats to use) and in the actual wikitext generated, XFDcloser uses {{R from less specific name}}} (note the extra closing curly bracket). See diff #1020394565 as an example. Tol | Talk | Contribs 20:57, 28 April 2021 (UTC)

I've created a pull request to fix this. --Pokechu22 (talk) 21:18, 28 April 2021 (UTC)

 In progress. I've merged the pull request (thanks Pokechu22), but am awaiting restoration of permission on testwiki (so I can do a test deployment there before deploying to the live version here). - Evad37 [talk] 04:56, 29 April 2021 (UTC)

 Fixed @Tol and Pokechu22: - Evad37 [talk] 02:52, 4 May 2021 (UTC)

Bug: AfD merge closure didn't follow retarget

Steps:

1. During its AfD, 2007 Ridgewood Junction Train Derailment moved to 2007 Ridgewood Junction train derailment
2. I closed Wikipedia:Articles for deletion/2007 Ridgewood Junction Train Derailment as merge
3. XFDC prompted me what I thought said that it would use the above retarget, not the original source, which is good/makes sense
4. Bug: XFDC added merge and closure tags to the original location, not the moved target[12][13]

czar 05:02, 14 May 2021 (UTC)

So for what it's worth, I don't think this is a bug so much as a "language needs to be clarified" issue, because I've had this same issue pop up for me occasionally with TfD closures; every time I have to sit there and parse out exactly what it's saying in order to make the correct choice. It shouldn't take that much effort, so maybe we should think about rewording the notice to be more clear? Primefac (talk) 12:38, 14 May 2021 (UTC)

I don't recall what exactly the language read but in any event the default should be to use the latest target page. If useful, always happy to assist with wordsmithing! czar 06:32, 16 May 2021 (UTC)

Okay, assuming I'm reading the MW page correctly, the warning is Actions will be applied to this redirect's target page. To use the nominated page instead, undo the redirection before continuing.

I think the confusion here for me is the thought of "why wouldn't we want to use the nominated page?" While in reading it now it makes a reasonable amount of sense, in looking back I can see how one could get confused. Primefac (talk) 10:49, 16 May 2021 (UTC)

• Similar case for Wikipedia:Articles for deletion/B. Griffith. The article was moved during the discussion and upon my closure, XFDC updated the original target, not the new target. No prompt this time, though, just a notification that it couldn't find a tag to remove on the page. czar 03:49, 23 May 2021 (UTC)

Backlink question

I just started using this gadget, and I'm having problems understanding the unlinking part. The first part is telling it to unlink backlinks; what exactly does that do? The next part is it gives me a list of pages with the unlinked badlinks saying that they can be edited unless they are transcluded. The problem is there's no way to tell which pages listed can in fact be edited. The it unlinks the backlinks (again not sure what that means). Usually it then gives me options as to what to do with the unlinked badlinks (the one I'm doing right now doesn't give me any options, not sure why). What I want to do depends on the page. If, for example, it's a page that lists notable people, I'd want to remove the entry. If, however, it's an actor and they're in a cast section of the page, I want to leave the item but remove the redlink. I don't see how to do the latter.

Thanks for any help.--Bbb23 (talk) 15:28, 3 June 2021 (UTC)

Lot to unpack here, I'll try to hit everything.

• As you guessed, unlinking just removes the wikilinks. If Bar is being deleted and Foo has a line like And it is said that bar won the race... it would just turn bar into bar.
• If a page is listed on the unlinks menu, it will be edited.
• XFDC checks to see if the entry is a list entry or in running prose. If it is a list entry, it gives you the option to either delink (such as your cast section example) or remove entirely (such as the "notable people" lists). If it's not giving you any of those options, that means it's either in running prose or it cannot parse the text (and will just remove the link).

If I missed something or you'd like some extra clarification, let me know. Primefac (talk) 15:34, 3 June 2021 (UTC)

@Primefac: I was hoping you'd help; thanks! If I understand properly, when the software unlinks the backlink, it removes the wikification, but at what point in the process does it do that (you mention it twice)? As for the unlinks menu, based on what you said, I think I misunderstood. I thought the software meant that I could edit it at that point by right-clicking, etc.--Bbb23 (talk) 15:44, 3 June 2021 (UTC)

It does this after you've closed the discussion (i.e. completed all of the steps). And it's nice, because the script will do all of your editing for you! Primefac (talk) 15:46, 3 June 2021 (UTC)

The automated part is great, but I'm still not sure what I have to do during the process to achieve the removal of an item or the dewikification of an item. Oh well, this last one I did had nothing to do at the end, which made it easy. If I get another one that does require me to make choices (delete item and I don't remember the other choices), I'll do what I think is correct, and if it doesn't work, I'll be back here. :-) --Bbb23 (talk) 15:52, 3 June 2021 (UTC)

Sounds good. Sometimes the best way to figure it out is just to do (especially if it's something relatively "rare" like closing AFDs). Primefac (talk) 15:57, 3 June 2021 (UTC)

Feature request: Delete TFDd template subpages

Tracked in github.com
Issue #85

It would be nice to hit the /sandbox, /doc, and /testcases subpages when a TFD is closed as delete (now, rather than holding), and possibly associated redirects. (Maybe with checkmarks? Not sure.) In almost all my recent deletes there I've had to open the 'subpages' link and then manually G8 the remaining subpages. Izno (talk) 16:47, 24 May 2021 (UTC)

Seconded. I think this should be a default-on option (since there are very rarely occasions where you wouldn't want to delete the subpages) but it would definitely save some extra clicks. Primefac (talk) 17:09, 24 May 2021 (UTC)

Alternatively, a list of all subpages, with doc/testcases/sandbox default checked, maybe with a link to transclusions of each? Musing. Izno (talk) 22:27, 6 June 2021 (UTC)

{{Tfd links}} has a "subpages" link, which I will often use to pull up everything, then I use Twinkle's dbatch feature to G8 them all. I know that's not what you're going for, but a list of all subpages is available. Primefac (talk) 22:52, 6 June 2021 (UTC)

Right, and that's the principal link I use to make sure I hit the testcase, doc, and sandbox pages. Sometimes there are others ("/core") and it would be convenient to skip having to continue hitting that link to check for the others if testcase/doc/sandbox pages get integrated into the gadget. Izno (talk) 23:25, 6 June 2021 (UTC)

True, though I still think the original idea of just "check this box to delete subpages" would be easiest (granted, what sounds easiest and what's actually easiest to code are rarely the same thing...). Primefac (talk) 23:34, 6 June 2021 (UTC)

Mine requires getting a list of the subpages. If you go the way of no auto, or all auto checkmarks, you don't have to hardcode any subpage names. If you want some but not all, or you only want the 3 names, then that requires hardcoding subpage names. Getting all requires a different routine, but you also have to check for existence in the other case, which you don't have to do in the all case. Izno (talk) 01:05, 7 June 2021 (UTC)

I definitely wasn't thinking of hardcoding any subpages (since even if you said "delete /doc, /sandbox, and /testcases" there will likely be ones that are missed anyway), being in favour of "all or nothing". Primefac (talk) 01:09, 7 June 2021 (UTC)

Oh, I'm still tossing stuff around, feeling good about suggesting all subpages now. Vibing, as it were. ~ Izno (talk) 01:23, 7 June 2021 (UTC)

Bug: AfD circular redirect unlinker removed wrong AfD tag

1. While closing Wikipedia:Articles for deletion/Devel Sixteen as "redirect", XfD correctly unlinked Devel Sixteen on Devel Motors
2. However it also removed an AfD tag during the unlink, not the "Devel Sixteen" tag (the one it was unlinking) but one for the target article, "Devel Motors": Wikipedia:Articles for deletion/Devel Motors

So XFDC should only perform the unlink and not remove AfD tags. If it does the latter, it might need some sort of check to make sure the AfD tag matches the AfD in question. czar 13:37, 23 July 2021 (UTC)

Recognize Module:Tfd links

TfD is currently experiencing some quite severe PEIS issues with {{Tfd links}} being the main culprit. By using the module directly instead could reduce the size significantly. Therefore I believe XfDCloser should on top of the * {{tfd links|__PAGE__}}\n format also recognize * {{#invoke:tfd links|main|__PAGE__}}\n. --Trialpears (talk) 22:04, 3 August 2021 (UTC)

Issues with AfD log

Please take a look at Wikipedia:Articles for deletion/Log/2021 August 7 - there are entries which were relisted but which were not properly commented out (manual fix) nor copied over (idem) to the next log page. RandomCanadian (talk / contribs) 17:27, 15 August 2021 (UTC)

If this is a one-off issue, then I would chalk it up to something user-side, with maybe the window being closed too soon, or the script hiccuping. Unless you're seeing it repeatedly I don't think it's necessarily an issue that needs looking at. Primefac (talk) 11:24, 30 August 2021 (UTC)

Wikipedia namespace talk pages not getting deleted

Please see this discussion. It appears that XFDcloser is unable to delete pages in the Wikipedia talk: namespace if they are nominated directly. Evad37, is there an easy way to solve this issue? ✗plicit 06:47, 16 September 2021 (UTC)

XFDCloser not deleting main article

When I closed Wikipedia:Articles for deletion/Living presidents of the United States, XFDCloser deleted the secondary article (Living vice presidents of the United States), but not the main one. I haven't closed any other multi-AfDs to be able to tell you if this is a recurrent problem, but this behaviour was unexpected. Did I do something wrong, or is this a bug? – bradv^🍁 23:43, 4 September 2021 (UTC)

I've seen this happen to a couple other articles this summer. I came across them because other editors tagged them for uncontroversial speedy deletion, citing the AFD discussion. I wish I could remember what they were but just wanted to confirm that this has happened more than once. For some reason, when Bradv closed this AfD, there were many redirects that were deleted but not the main article or talk page. I think it could be because of the huge edit history of the article (1909 edits), would it make sense that in these cases, articles have to be deleted individually? I know from WP:REFUND that restoring articles with huge edit histories can be a challenge. Liz ^{Read! Talk!} 03:04, 5 September 2021 (UTC)

Possibly tangential, but lately I’ve had to G6-tag a few articles which XFDcloser missed simply because they got moved during the discussion period. Not sure if these may be some of the cases Liz is referring to. --Finngall ^talk 07:16, 16 September 2021 (UTC)

And I'm not sure if THIS is related, but over this summer I've been working through a huge list of Orphaned talk subpages. I'd say at least a 1/3 of them are leftover archived talk pages from articles that were deleted in an AfD. Two points: a) I can't say with certainty that in every one of these cases, XFDcloser was used but it was used in some of them and b) this list is from 2020 so this might be an issue you've already addressed. But if not, it seems like XFDcloser might not be effective at deleting article talk subpages, like talk archives, when an AfD discussion is closed as "Delete". Thank you. Liz ^{Read! Talk!} 22:28, 26 September 2021 (UTC)

I don't think the issue here is related, but #Feature request: Delete TFDd template subpages above does discuss the problem. Primefac (talk) 22:33, 26 September 2021 (UTC)

That discussion seems relevant to the problem I mentioned, Primefac. I probably should have had some familiarity with using XFDcloser before bringing up possible problems here. ;-) I just thought there might be some connection. Liz ^{Read! Talk!} 00:55, 27 September 2021 (UTC)

Minor change in CFD templates

Some excess colons were removed {{Cfd2}}, {{Cfm2}}, {{Cfr2}} and {{Cfs2}}, per Template talk:Cfd2#Remove leading colons. I don't know if this would break XFDcloser, but if something starts going wrong in CfD closure process, this could be the reason. – SD0001 (talk) 03:14, 25 October 2021 (UTC)

Curious error

Special:Diff/1055247133-- not sure what happened, bu it wasn't me... Eddie891 ^Talk _Work 19:31, 14 November 2021 (UTC)

It looks like a Deletion Sort page got copied into your close. I don't see how the closer could have pulled that information, but I also can't see you copy/pasting an entire delsort page into your close. I wonder if a stray transclusion somehow got subst... Primefac (talk) 19:49, 14 November 2021 (UTC)

ADf merge to but not merge from

working on the merge backlog, I'm coming across quite a few articles (in the May list I'm working on) where Afd-merge to was added without adding Afd-merge from on the target, and these seem to be generate by the use of XFDcloser. For example:

• this edit by Eddie891.
• Edits by Missvain (related to Institute of Tropical Medicine, Nagasaki University)
• Edits by Czar (related to Chowchilla Wye)
• many others

I wonder whether XFDcloser might include this step (as suggest in the Adf-merge to documentation) to include this step, as it should help to advertise the need for a merge on the high-traffic target pages. Klbrain (talk) 13:23, 9 October 2021 (UTC)

OK, it looks like this was my mistake ... me Afd-merge from is on the talk page, while merge from is on the article page ... different conventions from different projects ... we can live with it. Klbrain (talk) 21:09, 16 November 2021 (UTC)

Bug: Escaped character breaks "Review unlinked list item" link

Review unlinked list item

A backlink has been removed from the following list item:

List: List of children's television series by country#Australia

I saw this today, and when I clicked through the link it brought me to this broken link. So there's an error in the URL encoding/escaped character. Note that in my example I replaced the ampersand character (as it was displayed to me) with the character reference so that it would display properly here. But as it reads to you, that's how it looked to me. czar 16:21, 25 November 2021 (UTC)

Forced abort with rationale lost due to anchors in RfD header

See Special:Diff/1064766039. Some well-meaning person, apparently not realizing that {{subst:rfd2}} includes an anchor to serve as a fallback for when the redirect's name isn't the same as the header, added a bunch of anchors to this RfD section heading. When I went to close the RfD, it aborted because it could not find the section heading, showing a grayed-out abort button and a blue close button, without any message (like Twinkle has and SPIhelper have for failed-to-saves) giving me a copy of what I'd written.

The failure seems like a bug—the script shouldn't rely on the displayed section heading being the same as the wikitext section heading, because that's not a guarantee with MediaWiki—but would be less of an issue if the feature I referenced were implemented. -- Tamzin^{[cetacean needed]} (she/they) 03:30, 10 January 2022 (UTC)

Date not updated when relisted at RFD

Hi, it was brought to my attention that XFDcloser is not updating the dates on templates when relisting WP:RFD discussions, as it failed to do here. This is an issue I noticed when a second relist was performed, but now it doesn't seem to update the date at all. ✗plicit 00:51, 26 June 2021 (UTC)

I have noticed this as well; it does not appear to be a one-off issue. Primefac (talk) 11:25, 30 August 2021 (UTC)

Also in this (and related) edit by @Tavix; XFDcloser now failed to update the template on the redirects completely when relisting for a second time. ~~~~
User:1234qwer1234qwer4 (talk) 14:11, 14 November 2021 (UTC)

@Evad37:, as you can see in [this diff], this is still a bug. The date is not being updated on the redirect page when relisting the first time. On second and subsequent relists, the gadget returns "Updating link in nomination template: Skipped (#) Nomination template not found on page".-- Aervanath (talk) 02:53, 11 January 2022 (UTC)

• @Explicit, Primefac, Aervanath, and Evad37: There's nothing to fix ... there is no issue. The purpose of this field is to mark the date of which the redirect was nominated, not the date of the most recent relist. The maintenance categories for RFD which pertain to which month the redirect was originally nominated (such as Category:Redirects for discussion from June 2021 as referenced in the first diff) are triggered by this field. The other purpose is to link to the page of the date which the redirect was initially nominated, and then the reader has to use the "relisted at..." links (the amount of links is equal to the amount of relists) to get to the date/page of the most recent relist. From my perspective, the issue is with the aforementioned sentence; if that is truly the issue, the problem is with the current RFD procedures for relisting, not the XFDcloser gadget, which per my explanation is running properly per RFD's current relisting setup. Steel1943 (talk) 00:33, 12 January 2022 (UTC)

  Thanks for the explanation. Primefac (talk) 07:34, 12 January 2022 (UTC)

  @Steel1943: Thank you for the clear explanation! However, I still think there is an issue with the gadget returning "Nomination template not found on page" incorrectly in this cases. I don't think any of us would have noticed anything "wrong" if we hadn't received this message.-- Aervanath (talk) 14:20, 12 January 2022 (UTC)

Feature request: Show only closure-eligible discussions

I love the little "Show/Hide closed discussions" button but it would be even better to have its corrolary now that XFDC can see closure-eligible discussions. It would only show the "amber" and "green" discussions (i.e., ready for closure), filtering out the "red", when viewing any given AfD log. I imagine there are a few different ways to approach, but one idea would be to use the same button and toggle between the three filtered states (Show all discussions/Hide discussions ineligible for closure/Hide only closed discussions). Another option would be to ignore that third option and only toggle between the first two. czar 00:34, 10 January 2022 (UTC)

would this prevent using it for SNOW closes? DGG ( talk ) 20:08, 12 January 2022 (UTC)

Old afd templates placed on talk pages of redirects

Tracked in github.com
Issue #66

TODO - investigate this issue when an AFD'd page is moved. Situation can also occur if the page is just replaced with a redirect to an already-existing page (an out-of-process redirection, since that shouldn't be happening during the AFD discussion) XFDcloser should be asking the closer if the actions should be applied to the redirect's target or the redirect. My suspicion is that the wording presented to the closer using XFDC isn't clear enough, so the option they choose results in the old afd template being placed on the wrong page. Another possibility is something going wrong within the script itself. Ping @Wbm1058: who has come across several, see their contributions on 2022-01-11 approx 05:00 to 06:00UTC - Evad37 [talk] 14:15, 11 January 2022 (UTC)

Just had an idea: the script should be able to check the age of redirect. If created as the result of a move, it would have been created after the xfd discussion started. Whereas an out-of-process redirection would just be an additional edit, so the page would have been created before the xfd discussion started. - Evad37 [talk] 14:25, 11 January 2022 (UTC)

Thanks Evad. I pinged you because the infobox at Wikipedia:XFDcloser indicates that you are the author. If there are other authors, can you add their names to the infobox? If the script does write on the redirect page rather than follow the redirect, it should not write on the top of the page, destroying the redirect, unless it blanks the page first, removing the redirect and all the templates below it. Thanks, wbm1058 (talk) 14:27, 11 January 2022 (UTC)

Another recent example: see the page history of Talk:USS LSM-479. I also left the template on Talk:USS LSM-478 so in some cases it may be best to leave the template on two pages. Thanks, wbm1058 (talk) 14:22, 19 January 2022 (UTC)

Redirected pages & talk pages bug

Extracted from Wikipedia talk:Articles for deletion#Bug/edge case in XFDcloser tool (permalink):

By the time Wikipedia:Articles for deletion/İkinci Ərəbcəbirli closed as "speedy keep" the page had been moved to Arabdzhabirli Vtoroye "per WP:NCGN."

When Buidhe closed it using the XFDcloser tool, it put the {{Old AfD multi}} template at the top of the redirect page, breaking the redirect.

I removed it from the redirect and added it to the renamed page.

Please consider fixing this issue in a future release. If a fix is not feasible, please consider detecting it as an error or warning if that is not already being done. davidwr/(talk)/(contribs) 16:27, 27 February 2020 (UTC)

Thanks for catching this! Although it would be nice if the issue were fixed, I will just take it as a reminder to double check AfD closures. buidhe 16:33, 27 February 2020 (UTC)

Handling of nominated pages that have become redirects is a bit tricky – if it is the result of a move then the outcome of the XfD discussion should be applied to the target, but if it is the result of a bold redirection to another existing page, then the XfD outcome should be applied to the redirected page. The script detects whether the nominated page is a redirect, and will ask the closer what to do. (It might be possible that the nominated page is made into a redirect between when the script checks and when it tries to edit it – not much that can be done about that, but the script will report a warning message if it doesn't find the nomination template on the page it edits.)
So while that part of this situation is not a bug, or at least not something that can really be fixed, breaking the redirect is a bug – the old xfd templates are intended to be paced after the #REDIRECT line (and any other existing content). - Evad37 [talk] 00:38, 28 February 2020 (UTC)

If the script is alerting its user of a potential problem, then that is enough. Well, that and fixing the actual template-placement bug. davidwr/(talk)/(contribs) 03:40, 28 February 2020 (UTC)

Found this thread while following up on the unusual situation discussed at User talk:Sandstein § Article still around six months after delete close (Special:Permalink/1067398279). Was going to suggest a feature similar to what Evad37 says is meant to already happen. Sandstein, I know it was six months ago, but I don't suppose you recall if you got any warning message when deleting that page? And @Evad, is the warning in this case just the generic "not tagged" warning, or does it explicitly say that the page is now a redirect? Because, if the former, I could see that bamboozling a closer who gets the "not tagged" warning, clicks the link, gets redirected to the new page, doesn't notice that they've been redirected, sees the XfD tag, and thinks "Huh, XFDcloser being weird I guess". -- Tamzin^{[cetacean needed]} (she/they) 08:20, 23 January 2022 (UTC)

@Tamzin, I don't recall any message; if one had appeared I guess I'd have followed it up. Sandstein 16:26, 23 January 2022 (UTC)

TFD relist - update request

Following this discussion it was determined that new TFD discussions should be added to the bottom of the relevant daily log page. At this discussion it was mentioned that XFDC wasn't updated, and when relists occur they are being added at the top of the page. I don't know how easy a fix this will be, but changing it would be much appreciated so that XFCD is in line with current TFD practices. Thanks! Primefac (talk) 15:44, 5 February 2022 (UTC)

Result is a new sentence

The "Result is a new sentence" checkbox does not really mean what it says. What it actually does is "Rationale is a new sentence". That's had me confused for years. SpinningSpark 17:29, 3 February 2022 (UTC)

That gave me an idea: can the rationale field be pre-filled with a period instead of having that checkbox? If the rationale is not a new sentence, it'd be easier to backspace the period over unchecking a box since that field will already be used. It has the additional benefit of being able to use a comma directly after the result without having an awkward space after it. -- Tavix ^(talk) 02:23, 4 February 2022 (UTC)

It would need to prefill a period+space otherwise people would repeatedly miss out the space after the period. But that all sounds a bit of a bodge to me. Better to keep it as it is but change the wording of the tick box to what it really does. SpinningSpark 17:21, 11 February 2022 (UTC)

It works for me, now that I know what it means, as it does show a preview of what it will save.– Fayenatic London 21:04, 14 February 2022 (UTC)

CfD bulk rename

I closed a CfD at Wikipedia:Categories for discussion/Log/2021 December 4#Recording artists using XfDcloser with consensus to rename all 5 categories, and the outcome wasn't implemented automatically. See also this AWBREQ report, where I have filed a request to clean this up. –LaundryPizza03 (dc̄) 05:08, 11 February 2022 (UTC)

Nah, it doesn't do anything much for CFD renames or merges. For such closes I currently use the "Custom" option, to save entering data into XFDcloser that it will only ignore. The only help that XFDcloser gives for such closes is to save us typing the Cfd top and bottom templates. – Fayenatic London 21:03, 14 February 2022 (UTC)

I've had the same issue with Wikipedia:Categories for discussion/Log/2022 February 3#Category:College athletic coaches in the United States. What's the most efficient process for renaming these five categories? Do we have a bot somewhere that can lookup each page in each category and edit the category name? It seems like a lot of time-wasting busy work for a human to do this. Jehochman ^Talk 17:19, 15 February 2022 (UTC)

@Jehochman: This is exactly what WP:CFD/W is for. Since you're not an admin anymore, you can list it here instead. bibliomaniac15 17:36, 15 February 2022 (UTC)

Relistings not working

An issue came up at WP:AN involving outstanding AfD closures. Upon investigation, I found that a user had re-listed seven AfDs using XFDcloser, but whilst they were all removed from the February 3 log, only two of them had been added to the February 10 log (Link). Is this likely to be a glitch at the user's end, or is it something that might happen again? Black Kite (talk) 22:59, 14 March 2022 (UTC)

If it's a singular user, I suspect it's an issue on their end (likely closing the window before the full process has completed). Primefac (talk) 09:43, 15 March 2022 (UTC)

Ta. Pinging Coffee in case they were unaware. Black Kite (talk) 10:46, 15 March 2022 (UTC)

That, uh, might be a little difficult. Primefac (talk) 10:56, 15 March 2022 (UTC)

Any interface editors willing to help maintain this gadget?

So ... there's been some bugs with this gadget for a while, especially bugs with matters which pertain to WP:RFD. In addition, the only editor who seems to maintain this tool has not edited for about 3 months now. Unless someone else wants to take over responsibility for maintaining this gadget, I think it's time for it to no longer be a gadget. Steel1943 (talk) 03:28, 28 April 2022 (UTC)

(Section name updated to reflect current/new goal of the discussion.) Steel1943 (talk) 22:38, 28 April 2022 (UTC)

If I had more time, I would, but if I had more time I'd probably be an IntAdmin already anyway... I'm sure we can find someone to offer assistance. Primefac (talk) 09:58, 28 April 2022 (UTC)

I don't do much XFD work any more, but it's hard for me to imagine that process running well without this script. I'd certainly support using a grant to support this work if that would incentivize somebody to take this on. -- RoySmith (talk) 13:31, 28 April 2022 (UTC)

• I've notified the interface administrators' noticeboard of this discussion. Steel1943 (talk) 21:10, 28 April 2022 (UTC)
• No, I see 0 reason to "demote" this. The tool functions reasonably for most discussions. And anyway, if 3 months without maintenance is enough to demote a gadget, you need to review our list of gadgets as many haven't been maintained in the past decade. --Izno (talk) 21:29, 28 April 2022 (UTC)
  • Interesting tangent, and that may be worthwhile. However, my point here is that nonetheless, bugs are bugs, and in most cases, unless bugs are squashed, they multiply. Steel1943 (talk) 21:33, 28 April 2022 (UTC)

    The software functions reasonably in most other circumstances. If we need to make some small adjustment that RFD presently needs cleanup post-use, or to provide a note on WT:RFD of the same, that seems acceptable to me. This does not constitute a "de list as gadget" kind of emergency. Izno (talk) 22:16, 28 April 2022 (UTC)

    Right. I think the goal of this discussion has swayed more from "delist this gadget" to "help maintain this gadget", so maybe I should update the section header and add an anchor ... so I'll do that. Steel1943 (talk) 22:36, 28 April 2022 (UTC)

    Notably, intadmins are only necessary to promote scripts to the production page. Anyone is welcome to propose and test improvements. — xaosflux ^Talk 22:49, 28 April 2022 (UTC)

    If that is the case, I may have been mislead above... Steel1943 (talk) 22:53, 28 April 2022 (UTC)

    I'm assuming the confusion is off of my comment, which was meant as a "I'd be helping out in this sort of area more often" comment than attempting to indicate that only IntAdmins can update the Gadget. As alluded to above, the tool is actually hosted on Github, where anyone can put forward improvements. Primefac (talk) 09:40, 29 April 2022 (UTC)

Backlinks, watchlist

Hi! At Wikipedia_talk:XFDcloser#Advance_notice:_Version_4_deployment, it was noted that @Randykitty's request re: not having backlinks clutter watchlist was addressed. Do any of the gadget users know where to toggle that? I hadn't much worried about it, until Wikipedia:Articles for deletion/Futsal positions murdered my watchlist. Thanks! Star Mississippi 16:47, 30 April 2022 (UTC)

Pages in the "Template" namespace which XFDcloser is reliant on

Can anyone produce a list of pages in the "Template:" namespace which XFDcloser is reliant on? I'm wanting to create a template similar to {{Twinkle standard installation}} to put on those pages to notifying editors to take care when editing those templates to make sure the edits don't break XFDcloser if they are major. Steel1943 (talk) 02:09, 1 May 2022 (UTC)

• At this point, I think I figured out most of them. I created {{XFDcloser standard installation}} to tag templates which are utilized by XFDcloser and placing the templates in Category:Templates used by XFDcloser. Feel free to tag any additional templates I may have missed. Steel1943 (talk) 03:20, 1 May 2022 (UTC)

(Also, during this process, I discovered that XFDcloser uses {{Old AfD multi}} and {{Oldtfdfull}} instead of {{Old XfD multi}} and {{Old TfD}} respectively to tag talk pages of closed WP:AFDs and closed WP:TFDs respectively, which is why I tagged the redirects with the template as well. Maybe XFDcloser needs to be updated to transclude the targets of the redirects rather than the redirects themselves?) Steel1943 (talk) 03:20, 1 May 2022 (UTC)

XFDcloser not deleting pages at RFD

Hello, folks,

I closed some deletion discussions at Wikipedia:Redirects for discussion/Log/2022 March 13 and noticed that the redirects that were supposed to be deleted were not and the RFD tags were still on the pages. I thought, of course, this must be me but then I noticed other discussions closed as "Delete" by Explicit also had existing redirects that were supposed to be deleted but were not. XFDcloser closes the discussion properly, just doesn't follow through on the deletion decision. I'm not sure if this is also an issue on other deletion discussion forums but if it was, I'd expect to see messages here already. Thanks for any help you can provide. Liz ^{Read! Talk!} 22:19, 20 March 2022 (UTC)

I also see that one discussion involving Iocane powder that I closed yesterday, was supposed to retarget the page but it is still listed as being subject to an RFD discussion and was not retargeted. So, this problem, at least on RFD, has existed since yesterday and involves more than just deletions. Liz ^{Read! Talk!} 22:22, 20 March 2022 (UTC)

Just closed a few discussions at AFD and deletion is not a problem so I guess this is reserved for RFD or, at least, the March 13, 2022 RFD. Liz ^{Read! Talk!} 22:45, 20 March 2022 (UTC)

Now I see AFDs I closed as "No consensus" still have the AFD tag on the article, even after the deletion discussion has been closed. Liz ^{Read! Talk!} 02:20, 21 March 2022 (UTC)

Same behavior on today's page, Wikipedia:Redirects for discussion/Log/2022 March 14. Hello, Primefac and Black Kite, or any developers monitoring this page? I thought this would get a response but now I see lots of unanswered messages on this page so I'm no longer hopeful. 22:38, 21 March 2022 (UTC)

And by every discussion listed on the page, it has "XFDcloser loading..." so I guess the problem is that XFDcloser isn't loading on the page or the discussions it contains. Liz ^{Read! Talk!} 22:50, 21 March 2022 (UTC)

I had seen the "XFDcloser loading..." but didn't realize that XFDcloser is completely broken. My closes at RfD also have not taken effect. Jay (talk) 05:48, 22 March 2022 (UTC)

It relists RFDs fine, but I found out the hard way that it'll no longer delete there. Hog Farm _Talk 20:27, 1 April 2022 (UTC)

XFDC not removing RFD tag from redirect when closing discussions or tagging talk page with old RFD

The title says it all. Steel1943 (talk) 22:08, 25 March 2022 (UTC)

XFDCloser is broken since 20th and all closes from then must be fixed manually. See #XFDcloser not deleting pages at RFD above, and WT:Redirects for discussion#XFDCloser is broken. Jay (talk) 07:44, 26 March 2022 (UTC)

Turned this into a subsection of the section immediately above, since it's a duplicate. Primefac (talk) 08:01, 26 March 2022 (UTC)

Evad37 is the sole developer, and last made an edit on January 22. MediaWiki:Gadget-XFDcloser.js last updated on 31 January 2021‎, deploying version 4, and MediaWiki:Gadget-XFDcloser-core.js last updated 22 January 2022‎ (fix missing rationale input). MediaWiki:Gadget-XFDcloser-core.css was deployed 31 January 2021‎ (version 4), and hasn't been changed since. I don't know what could have changed around March 20 that would have broken anything that previously worked, other than maybe a MediaWiki software update. Anyone with a good working knowledge of javascript might investigate to better diagnose the issue. – wbm1058 (talk) 02:05, 28 March 2022 (UTC)

...or someone changed a template or other page that this script might depend on, a change that possibly should have been coordinated with the gadget developer to avoid breaking things. – wbm1058 (talk) 02:11, 28 March 2022 (UTC)

Hmm, Template talk:Redirect for discussion#Broken links in the article alerts, reported 23 March 2022. Might be related to the same breaking change. – wbm1058 (talk) 02:19, 28 March 2022 (UTC)

I came back here to see if it was just me but, no, it is XFDCloser. Odd that it is only happening on the WP:RFD pages and none of the other XfD ones. I'll see if Evad37 has email enabled. I've just avoided RFD since this all started. Liz ^{Read! Talk!} 20:25, 4 April 2022 (UTC)

As HogFarm said above, it relists fine, and updates the RfD discussion pages properly. The delete, retarget or keep changes at the redirect page has to be done manually. Jay (talk) 05:06, 5 April 2022 (UTC)

There is one RfD discussion that has no close or relist links. I even went back to a decades old RFD page and it also had "XfDCloser is loading...." on the discussions so it's a system problem not just an issue with recent RfD discussion pages. I even saw that XfDCloser loading message on an AFD so I hope the problem isn't expanding beyond RfD. I emailed Evad37 a few days ago but if he has other commitments, it might be a while before this problem gets resolved. Liz ^{Read! Talk!} 05:37, 8 April 2022 (UTC)

I can't imagine this could be a bug in XFDcloser. My bet is that the gadget fails to figure out the name of the redirect from the nomination, and that in turn is probably down to the changes that were made to {{rfd2}} in early March. – Uanfala (talk) 21:53, 30 April 2022 (UTC)

• @Uanfala: I decided to test what you said, and ... that's not it. I referred the Rfd2 template back to a 2 July 2021 revision prior to the March 2022 revisions, and then attempted a test close. Well, the aforementioned diff was the only edit XFDcloser performed, meaning the theory that the issue is the recent edits to {{Rfd2}} seems to not be true. Steel1943 (talk) 22:35, 30 April 2022 (UTC)

  You don't see a difference because rfd2 has already been substed at nomination time. I've just done a test of my own and what I found out is what I'd thought. You can try it too: see the two test nominations at Wikipedia:Redirects for discussion/Log/2022 March 11#User:Uanfala/sandbox/tmpredirect: one with the current version of the rfd2, the other with the older. – Uanfala (talk) 23:12, 30 April 2022 (UTC)

  @Uanfala: Sure enough, I didn't catch that, and ... holy carp, that worked; all pages that XFDcloser was supposed to touch it touched. Hey Tamzin, per this discussion here, I'm going to revert your edits this year on {{Rfd2}} since they broke XFDcloser. I'll post this notice on Template talk:Rfd2 as well. I'd imagine you may have an idea about how to submit a change on Github to accommodate your recent changes, but for now, I think XFDcloser working is more valuable that the daily subpage making it known if the redirect itself is tagged or not. Steel1943 (talk) 23:44, 30 April 2022 (UTC)

  @Tamzin: Since I determined the first edit you performed this year on Template:Rfd2 to resolve a WP:LISTGAP issue did not have any part in breaking XFDcloser, I'm actually going to revert back to that version of {{Rfd2}}. Steel1943 (talk) 23:56, 30 April 2022 (UTC)

 Fixed ...sort of. XFDcloser will now work on any nominations at RFD that are opened after this time stamp. (Please see the above discussion or further details.) Thanks again to Uanfala for finding the issue that caused XFDcloser to break on closing RFD nominations. Steel1943 (talk) 02:12, 1 May 2022 (UTC)

@Steel1943: Thanks so much for handling this. I didn't realize any scripts were relying on the old behavior... I'll add a note to the /doc page once this is all resolved. I'll get to looking at this once I have a brain cell or two free. Meantime, would it solve the other half of the problem to run a regex-replace across all open log pages with [AJ]WB? -- Tamzin^{[cetacean needed]} (she/they) 03:44, 1 May 2022 (UTC)

Wikipedia:Articles for deletion/Gajab Thai Gayo !

neither @Liz nor I are able to close this AfD. I'm not sure if it's space exclamation point or another issue. It says there's an edit conflict, but none actually present. Star Mississippi 00:36, 8 April 2022 (UTC)

Hello, Star Mississippi,

If you see the long discussion above this one that started last month, there have been some major problems with XFDCloser that need to be fixed but the developer is AFW..away from Wikipedia. I don't know how quickly this can be addressed and we might need to go back to doing things manually. Liz ^{Read! Talk!} 05:33, 8 April 2022 (UTC)

Thanks Liz. I've luckily been able to close most. Hope the creator eventually returns. This is such a helpful tool. Star Mississippi 13:43, 8 April 2022 (UTC)

It was the page title. I replicated the above issue, then renamed the article (per sources), then renamed the sections of the AfD, then retried and was successful, so this is a bug. czar 13:58, 8 April 2022 (UTC)

thank you! Will someone please feed the gremlins. Star Mississippi 14:10, 8 April 2022 (UTC)

It is the same with a title that has quotes. I am not able to close WP:Redirects for discussion/Log/2022 June 27#Untitled The Legend of Zelda: Breath of the Wild sequel because the page to be deleted is Untitled ''The Legend of Zelda: Breath of the Wild'' sequel with quotes in it. XFDCloser gives error during the final Save step "Closing discussion: Aborted. Possible edit conflict detected, found section heading"Untitled The Legend of Zelda: Breath of the Wild sequel"". Jay (talk) 04:19, 4 July 2022 (UTC)

• @Jay: Those aren't quotes: Those are apostrophes. The creation of titles with consecutive apostrophes is restricted by the title creation blacklist, and has been for almost a decade now. (See here.) This means that someone who should have used " instead of '' when this title was created was someone who should have known better as an editor with a permission to bypass the title blacklist. Also, in most cases recently, such titles have qualified for WP:G6 due to causing technical issues since consecutive apostrophes are interpreted as wiki markup (provided the title is a redirect, of course.) Steel1943 (talk) 01:21, 16 July 2022 (UTC)

Aborted: Old log page not found

Is there a way to allow a clickthrough on this failure message? I often use XFDcloser to relist orphaned AfD discussions, which definitionally don't have an old logpage. Currently, this requires me to add them to a logpage and then relist it, which is fairly time-consuming. jp×g 23:35, 21 July 2022 (UTC)

Relisting discussions gitch

Hello,

Midway through looking through today's expiring AFD log page (Wikipedia:Articles for deletion/Log/2022 August 4), XFDcloser stopped completing relistings. It would relist the discussion on today's log page, for August 11th, but not remove them from the log for August 4th. So, I handled this manually. I had noticed that ocassionally, XFDcloser would do this with relistings (it's probably happened with me about 6 or 7 times) but doing this to two relistings in a row makes me worried that this will become a regular problem. Of course we can go edit the log page ourselves but XFDcloser is normally so reliable, I thought I'd bring the issue to the talk page. Liz ^{Read! Talk!} 22:55, 11 August 2022 (UTC)

RFD close wipes out all RCAT and category content on redirects

I added this to the main XFDC page for now; XFDC removes all other content, including WP:RCAT templates, whenever a WP:RFD is closed to any result that alters the nominated redirect. (Here is an example.) I think the fix here is to remove XFDC's ability to tag redirects with RCAT templates during a close (or fix XFDC's apparently greedy regex used when replacing the content of the redirect being retargeted), but I have no idea how to go about doing or suggesting that. Steel1943 (talk) 17:14, 19 August 2022 (UTC)

Undefined in edit summary while unlinking

Edit summary links to undefined here: http://en.wiki.x.io/w/index.php?title=Unified_Payments_Interface&diff=1108464577&oldid=1107719925 – SD0001 (talk) 09:31, 17 September 2022 (UTC)

Bug in leaving template:Old CfD

Please fix the bug in XFDcloser that sometimes omits the action parameter in {{Old CfD}}, e.g. [14]. I highlighted this as my "top request" for 2022 above.– Fayenatic London 08:06, 29 August 2022 (UTC)

The parameter is still being omitted. [15] – Fayenatic London 13:36, 12 October 2022 (UTC)

Relisting failure at CFD

This relisting edit recorded that a CFD discussion was removed from the 23 September log, but it was not inserted into the 1 October log. I have relisted it today.

Pinging Qwerfjkl in case they have any recollection of the event, although I doubt it after 3 weeks.

This talk page shows that similar failings have been occurring earlier this year with AfD relistings. Are these malfunctions linked? – Fayenatic London 17:57, 21 October 2022 (UTC)

XFDcloser continues to be an unsatisfactory tool for CFD. This relisting changed the heading and the link to duplicate those for another unrelated CFD on the same log page, and did not change the nominated category page, leaving no navigation from the category to the relisted discussion.

PLEASE can someone give attention to these reports? – Fayenatic London 12:50, 27 December 2022 (UTC)

This has been asked before with no response. Maybe cross-post to VPT? Primefac (talk) 13:12, 27 December 2022 (UTC)

@Fayenatic london, Evad37, the maintainer of XFDcloser, is inactive, and last made an edit on October 8. — Qwerfjkltalk 19:53, 27 December 2022 (UTC)

I would argue that (and the edit from September) are outliers, and that they haven't been active since late January. Primefac (talk) 20:00, 27 December 2022 (UTC)

Deleted: The Revels Group

I was wondering how I can get The Revels Group Wikipedia back up. CarsonHolland (talk) 19:12, 6 February 2023 (UTC)

CarsonHolland, this is not the proper location to ask such a question. Please read through WP:DRVPURPOSE to determine the proper course of action. Primefac (talk) 10:27, 7 February 2023 (UTC)

Close aborting because of colon space

Close is aborting for WP:Redirects for discussion/Log/2023 February 8#Invisible Child : Poverty, Survival & Hope in an American City. The error is Possible edit conflict detected, found section heading"Invisible Child : Poverty, Survival & Hope in an American City". Note that there is only one section header with that title. Perhaps something to do with the colon or space or space near the colon? Jay 💬 16:47, 15 February 2023 (UTC)

Redirect templates

Hi, I've noticed that XFDcloser automatically removes templates on a redirect page that aren't wrapped in {{Redirect category shell}}, such as {{Fictional character redirect}} and its siblings. This creates a hassle for the few editors who watch those redirects, as we then have to manually add the template back. Please fix this ASAP. Thanks. InfiniteNexus (talk) 05:55, 30 September 2022 (UTC)

@InfiniteNexus: Kinda late, but see #RFD close wipes out all RCAT and category content on redirects. I noticed this issue a long time ago, and posted it on the main XFDC page, considering this gadget's main contributor has been MIA for a while and no one else has taken the reigns to maintain this thing. Steel1943 (talk) 20:18, 10 April 2023 (UTC)

Well that is unfortunate. I had thought this issue only affected templates not wrapped in {{Redirect category shell}}, but apparently that's not the case. I hope Evad37 is doing well and will be back soon, but if not we may have to explore other options. InfiniteNexus (talk) 00:10, 11 April 2023 (UTC)

Relisting RfDs does not update the tag on the nominated page

When relisting RfD discussions, XfDcloser fails to locate the RfD tag to update the link. It is possible that the format of Template:RfD has changed since this feature was last updated. –LaundryPizza03 (dc̄) 12:05, 14 May 2023 (UTC)

@LaundryPizza03, has this only started happening recently? Since when? I don't see any possible changes here. — Qwerfjkltalk 11:50, 22 May 2023 (UTC)

@Qwerfjkl: I don't know. Are you able to reproduce the issue by relisting an old RfD? –LaundryPizza03 (dc̄) 12:43, 22 May 2023 (UTC)

I get errors for the talk pages, not the redirect pages. But Keep outcomes do not remove the RfD tags, and I have to do them manually. I was facing problems for a few days, and then on some days they worked fine. Jay 💬 14:46, 22 May 2023 (UTC)

Cfm-double

This is a courtesy disclosure that I have tinkered with Template:Cfm2 and Template:Cfd all (showing the parameter label target2 on the category page) in order to make Template:Cfm-double correctly prepare the standard discussion starter. I do not expect my edits to adversely affect XFDcloser, because the CFD log entries should still be in the same format, and I do not think the change in the category page template will affect the process for its removal. However, if XFDcloser now malfunctions with merges, then please revert my changes to those templates and ping me. – Fayenatic London 13:07, 31 May 2023 (UTC)